-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EREGCSC-2448-End-EUA-Session #1117
Conversation
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one comment.
if '//logout' in logout_redirect_url: | ||
logout_redirect_url = logout_redirect_url.replace('//logout', '/logout') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the conditional here. If //logout
is not in the variable, the replace
function does nothing. Same result.
✨ See the Django Site in action ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #EREGGCSC-2448 - End EUA Session
Description-
When users sign in to Eregulations using their EUA credentials, authentication is performed via EUA. During the sign-out process from Eregulations, it should terminate the EUA (Okta) session. Several steps were taken to implement this functionality:
The Eregulations application now identifies if the user signed in via EUA, allowing the logout button to sign them out of Okta. Different handling is applied if the user signed in through the Django admin, which has a distinct logout link.
The Okta logout API endpoint is utilized when the user is signed in through EUA.
Updates were made to the admin panel and policy repository to ensure the correct logout link is used.
To manually verify these changes, follow these steps:
EUA Admin signin
EUA Policy repository sign-in
Django Admin sign-in
Django Policy repository sign in
The logout form at the bottom right of the Policy Repository page exhibits consistent styling, whether accessed through Django or EUA sign-ins.