Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring #204

Merged
merged 23 commits into from
Aug 24, 2023
Merged

refactoring #204

merged 23 commits into from
Aug 24, 2023

Conversation

Mara-Li
Copy link
Member

@Mara-Li Mara-Li commented Aug 24, 2023

  • When possible, use the class to get settings, plugin, app... Instead of passing the object in arguments
  • Create an object that regroups all settings:
    • one for Repofrontmatter[]
    • One for repoFrontmatter (not array)
  • Create another instance for only repository parameters that regroup RepoFrontmatter and Repository
  • Rename folder to github for the publish folder

It allow a better reading of the function and prevent passing 5+ args

@Mara-Li
Copy link
Member Author

Mara-Li commented Aug 24, 2023

Review TODO

  • create a testing repository with random note
    • Some note must be shared in sandboxing
    • Another in testing-repo
    • Some note must have embed and links
    • Add some note with repoFrontmatter
  • Test modal review (deleted, edited...)

Commands

  • Publish all files
  • Publish all new notes
  • Publish new note and edited notes
  • Publish one note
  • Purge
  • Refresh

@Mara-Li
Copy link
Member Author

Mara-Li commented Aug 24, 2023

Every seems to work as expected.

@Mara-Li Mara-Li merged commit 2f226c0 into master Aug 24, 2023
@Mara-Li Mara-Li deleted the refactoring branch August 24, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant