Issue 1399 #1486
Merged
Issue 1399 #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am seeing now that I should not have included EPFRs, so I am removing them |
cmungall
reviewed
Jan 23, 2024
cmungall
requested changes
Jan 23, 2024
There was a problem hiding this comment.
We need DPs for things like fumes. Two candidates
- X fumes - fumes that have as part (particles of) X
- X fumes - fumes that are the (non-primary) output of an X process
I favor 2
We can still merge this PR in the absence of this but it is odd having both solder and solder fume and no connection between them
cmungall
reviewed
Jan 23, 2024
cmungall
reviewed
Jan 23, 2024
|
I'm assuming a DP will take time, so let's do that later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added electroplating fumes, soldering fumes, lead solder, non-lead solder, gasoline vapor, noise, road traffic noise, aircraft noise, secondhand smoke, environmentally persistent free radicals, and pneumatic drill.
I added a parent term for the two solders and a parent term for noises. Please see that you agree with the placement of noise and the placement of EPFRs, and pneumatic drill.