Support Bitcode Library #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
force-pushed
the
bclib
branch
2 times, most recently
from
331ea80 to
d274845
Compare
|
Can we separate out the invoke changes? I would like to hold on the bc changes until we have confirmed correctness, of the implementation. |
|
I'm fine separating out the invoke, though I'm inclined to get the bitcode library pieces in. I agree we should double check that reduction, but this change primarily enables the use of a bitcode library (off by default) and can have the reduction interchaged. |
vchuravy
requested changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled by default.