Forward bench #554
Open
Forward bench #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgymnich
force-pushed
the
forward-bench
branch
2 times, most recently
from
487b0db to
9a63f9c
Compare
tgymnich
force-pushed
the
forward-bench
branch
6 times, most recently
from
c8009d0 to
fe92f3e
Compare
tgymnich
force-pushed
the
forward-bench
branch
2 times, most recently
from
96b84d7 to
a853cad
Compare
tgymnich
force-pushed
the
forward-bench
branch
from
e75b695 to
5c2dddb
Compare
wsmoses
reviewed
Sep 4, 2022
| @@ -23,7 +23,7 @@ jobs: | |||
| llvm: ["7", "8", "9", "10", "11", "12", "13"] #, "14"] | |||
| build: ["Release", "Debug"] # "RelWithDebInfo" | |||
| os: [self-hosted] | |||
| timeout-minutes: 120 | |||
| timeout-minutes: 300 | |||
There was a problem hiding this comment.
We can probably split bench forward/reverse as two separate things (and I should start more CI)
There was a problem hiding this comment.
I would disable the fwd tests by default. At some point we need to decide on a subset of test cases that run in reasonable time.
tgymnich
force-pushed
the
forward-bench
branch
from
5c2dddb to
55e6b91
Compare
tgymnich
force-pushed
the
forward-bench
branch
from
55e6b91 to
a81862f
Compare
tgymnich
force-pushed
the
forward-bench
branch
3 times, most recently
from
ec7115f to
17b2e58
Compare
wsmoses
reviewed
Dec 28, 2022
| @@ -46,3 +46,5 @@ add_lit_testsuite(bench-enzyme "Running enzyme benchmarks tests" | |||
| set_target_properties(bench-enzyme PROPERTIES FOLDER "bench Tests") | |||
|
|
|||
There was a problem hiding this comment.
Can the file structure here be changed to have only one copy of the benchmark data?
tgymnich
force-pushed
the
forward-bench
branch
6 times, most recently
from
a2fbc48 to
95f317b
Compare
wsmoses
reviewed
Dec 29, 2022
This reverts commit 9873dd9.
tgymnich
force-pushed
the
forward-bench
branch
from
c7fffee to
f390670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.