Add VectorType to TypeAnalysis #857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayegun
changed the title
rayegun
changed the title
wsmoses
reviewed
Sep 27, 2022
| @@ -4254,6 +4254,24 @@ void TypeAnalyzer::visitCallInst(CallInst &call) { | |||
| llvm::errs() << *T << " - " << call << "\n"; | |||
| llvm_unreachable("Unknown type for libm"); | |||
| } | |||
| } else if (auto VT = dyn_cast<VectorType>(T)) { | |||
| // AFAICT there is no equivalent for VectorType? | |||
There was a problem hiding this comment.
You can remove the note.
However can you add a test?
See here for a sample (except just have it call the function you ran into with corresponding type signature): https://github.com/EnzymeAD/Enzyme/blob/main/enzyme/test/TypeAnalysis/cpuid.ll
There was a problem hiding this comment.
Also in your case I think the issue is not in the argument (here). But in the return ( a few lines below on say 4280)
|
bump @Wimmerer |
1 similar comment
|
bump @Wimmerer |
|
bump @rayegun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a note within about zero length VectorTypes. Seems to me that it is impossible by construction.
fixes #856