Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generalize broadcast_in_dims for setindex #518

Merged
merged 2 commits into from
Jan 12, 2025
Merged

fix: generalize broadcast_in_dims for setindex #518

merged 2 commits into from
Jan 12, 2025

Conversation

avik-pal
Copy link
Collaborator

fixes #512. broadcast_to_size_internal is correct. We need more information from setindex! indices instead to construct the correct array

@avik-pal avik-pal requested a review from wsmoses January 12, 2025 17:33
@avik-pal avik-pal merged commit 6ddc890 into main Jan 12, 2025
27 of 38 checks passed
@avik-pal avik-pal deleted the ap/dims_fix branch January 12, 2025 18:35
@glou-nes glou-nes mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect broadcast_to_size implementation
2 participants
@avik-pal @wsmoses