Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guardrail cutoff test #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add guardrail cutoff test #23

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
629be8e
Added support for guardrail cutoffs
Nov 19, 2024
a3f6178
version bump
Nov 19, 2024
6d91d0f
cleaned up test file
Nov 19, 2024
9df4f88
Reverted schema and version bump since change had already been made
Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eppo_metrics_sync/schema/eppo_metric_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,10 @@
"type": "number"
}
}
},
"guardrail_cutoff": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for ourselves that guardrail cutoffs will change a bit as we roll out protocols and the new create experiment flow.
cc @rohansub

"description": "The guardrail cutoff for the metric",
"type": "number"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name='eppo_metrics_sync',
version='0.1.0',
version='0.1.1',
packages=find_packages(),
install_requires=[
'PyYAML', 'jsonschema', 'requests'
Expand Down
7 changes: 7 additions & 0 deletions tests/yaml/valid/purchases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ metrics:
numerator:
fact_name: Purchase
operation: distinct_entity
- name: Guardrail metric
entity: User
is_guardrail: true
guardrail_cutoff: 0.03
numerator:
fact_name: Purchase
operation: distinct_entity
- name: AOV
entity: User
numerator:
Expand Down
Loading