-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
FF-2853 fix: rename eppo_rb to eppo_client (#19)
* chore: fix Cargo.lock checking in CI `cargo generate-lockfile` tries to update dependencies to latest version and thus fails with `--locked`, even if the lockfile itself is fine. `cargo update --workspace` only updates files from the workspace root and any packages that are missing in the lockfile. So it produces consistent result. * FF-2853 fix: rename eppo_rb to eppo_client For some reason, ExtensionTask ignored lib_dir during gem installation, so extension was installed to lib/eppo_rb and gem failed to function. Renaming import does not help because it breaks the build in local development. Rename eppo_rb to eppo_client, so extension name matches the installation directory. This is also what was recommended by rust gem template.
- Loading branch information
Showing
12 changed files
with
23 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,5 @@ | |
# in the ext/ directory. | ||
|
||
[workspace] | ||
members = ["./ext/eppo_rb"] | ||
members = ["./ext/eppo_client"] | ||
resolver = "2" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
ruby-sdk/ext/eppo_rb/Cargo.toml → ruby-sdk/ext/eppo_client/Cargo.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
ruby-sdk/ext/eppo_rb/build.rs → ruby-sdk/ext/eppo_client/build.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
fn main() { | ||
// Without this flag, building via `cargo build` fails with undefined references to ruby | ||
// library. This is fine as `eppo_rb` is going to be loaded as an extension by the host Ruby. | ||
// library. This is fine as `eppo_client` is going to be loaded as an extension by the host Ruby. | ||
println!("cargo:rustc-link-arg=-Wl,-undefined,dynamic_lookup"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,4 @@ | |
require "mkmf" | ||
require "rb_sys/mkmf" | ||
|
||
create_rust_makefile("eppo_rb") | ||
create_rust_makefile("eppo_client") |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters