fix: specify eppo_core path through local override (#12)

This is required so that eppo_rb/Cargo.toml does not include local path (which would have been used in gem install). Co-authored-by: Oleksii Shmalko <[email protected]>
Eppo-exp · Jul 18, 2024 · cb236b9 · cb236b9
1 parent f9c11e8
commit cb236b9
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -15,4 +15,3 @@
 
 /sdk-test-data/
 node_modules
-ruby-sdk/eppo-server-sdk-0.3.0.gem
diff --git a/ruby-sdk/.cargo/config.toml b/ruby-sdk/.cargo/config.toml
@@ -0,0 +1,3 @@
+[patch.crates-io]
+# Local override for development.
+eppo_core = { path = '../eppo_core' }
diff --git a/ruby-sdk/.gitignore b/ruby-sdk/.gitignore
@@ -12,6 +12,7 @@
 *.a
 mkmf.log
 target/
+*.gem
 
 # rspec failure tracking
 .rspec_status
diff --git a/ruby-sdk/Cargo.lock b/ruby-sdk/Cargo.lock
diff --git a/ruby-sdk/eppo-server-sdk.gemspec b/ruby-sdk/eppo-server-sdk.gemspec
@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.files = IO.popen(%w[git ls-files -z], chdir: __dir__, err: IO::NULL) do |ls|
     ls.readlines("\x0", chomp: true).reject do |f|
       (f == gemspec) ||
-        f.start_with?(*%w[bin/ test/ spec/ features/ .git .github appveyor Gemfile])
+        f.start_with?(*%w[bin/ test/ spec/ features/ .cargo/ .git/ .github/ appveyor Gemfile])
     end
   end
   spec.bindir = "exe"

diff --git a/ruby-sdk/ext/eppo_rb/Cargo.toml b/ruby-sdk/ext/eppo_rb/Cargo.toml
@@ -11,7 +11,7 @@ crate-type = ["cdylib"]
 
 [dependencies]
 env_logger = { version = "0.11.3", features = ["unstable-kv"] }
-eppo_core = { version = "1.0.0", path = "../../../eppo_core" }
+eppo_core = { version = "1.0.0" }
 log = { version = "0.4.21", features = ["kv_serde"] }
 magnus = { version = "0.6.2" }
 serde = { version = "1.0.203", features = ["derive"] }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,4 +15,3 @@

		/sdk-test-data/
		node_modules
		ruby-sdk/eppo-server-sdk-0.3.0.gem