FF-2839 fix: update ruby-sdk/Cargo.lock to include eppo_core from crates.io #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
force-pushed
the
ff-2839-fix-ruby-cargo-lock
branch
3 times, most recently
from
e38de07 to
e879b19
Compare
rasendubi
force-pushed
the
ff-2839-fix-ruby-cargo-lock
branch
from
e879b19 to
6ea7b35
Compare
rasendubi
commented
Jul 23, 2024
Comment on lines
+57
to
+61
| - name: Override eppo_core for testing | ||
| run: | | ||
| mkdir -p ~/.cargo/ | ||
| echo "[patch.crates-io.eppo_core]" >> "${CARGO_HOME:-$HOME/.cargo}/config.toml" | ||
| echo "path = '$PWD/eppo_core'" >> "${CARGO_HOME:-$HOME/.cargo}/config.toml" |
There was a problem hiding this comment.
With this, we should be able to run tests on installed gem
rasendubi
commented
Jul 23, 2024
Comment on lines
+299
to
+300
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "d21810a56968888dc45c5b10df36fbff2cdc8e56881766d48a28ad395c3de3e6" |
There was a problem hiding this comment.
This is the fix for the issue. The rest is to ensure we catch this error automatically in the future.
leoromanovsky
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Tested locally:
eppo-server-sdk 3.0.0 built to pkg/eppo-server-sdk-3.0.0.gem.
Successfully built RubyGem
Name: eppo-server-sdk
Version: 3.0.0
File: eppo-server-sdk-3.0.0.gem
➜ ruby-sdk git:(ff-2839-fix-ruby-cargo-lock) gem install /Users/leo/src/rust-sdk/ruby-sdk/pkg/eppo-server-sdk-3.0.0.gem
Building native extensions. This could take a while...
Successfully installed eppo-server-sdk-3.0.0
Parsing documentation for eppo-server-sdk-3.0.0
Installing ri documentation for eppo-server-sdk-3.0.0
Done installing documentation for eppo-server-sdk after 0 seconds
1 gem installed
A new release of RubyGems is available: 3.5.9 → 3.5.16!
Run `gem update --system 3.5.16` to update your installation.
✅ ✅ ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.