-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ruby): Enable ruby-sdk to be cross compiled ahead of time #42
Conversation
I got almost all of the main architectures working, except for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
How pre-built gems flow into ruby publish workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for picking this up; appreciate your attention to all the major details and pragmatic approach to not get sucked into the arm64
architecture.
Could you give a quick push to seeing if the linked example works and if not push ahead with the platform for now.
🚀 🚀 🚀
oh, another caveat is that it tries to build the gems with |
So... Let's approach it in two steps:
|
I'm gonna look into that next. There's a way to set up a workflow that publishes the gems for each platform after they are built. I'll look into that in a follow up PR if that's OK for you guys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I'm glad it's passing for macOS as well now. Need to disable cross_gems
for PRs/main before merging though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but please extract cross_gems
into own action that is triggered on Release
before merging.
cool, taking care of that now |
Description
This will allow us to, at gem build time, precompile the ruby-sdk gem to all supported environments, so users don't need to have
cargo
installed to install the gem, skipping the whole "Building native extensions. This could take a while..." annoyanceTesting
We support ruby versions 3.0 and above
Also added Github action to cross compile as part of CI. We can add an upload step after, that part is still TBD
References
manylinux2014
rake-compiler/rake-compiler-dock#122