FF-3390 fix(python): fix typing information for Configuration.__init__ #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on initialization (FF-3390)
rasendubi
changed the title
rasendubi
reviewed
Oct 15, 2024
Comment on lines
9
to
24
| # Note: Before publshing v5.0.0 | ||
| # | ||
| # Users current have to initialize the configuration like this: | ||
| # | ||
| # Configuration(some_bytes, some_other_bytes) | ||
| # | ||
| # In v5.0.0, we will add a named parameter to the constructor to make this | ||
| # more clear. | ||
| # | ||
| # Users will be able to initialize the configuration like this: | ||
| # | ||
| # Configuration(flags_configuration=some_bytes, bandits_configuration=some_other_bytes) | ||
| # | ||
| # Changes: | ||
| # | ||
| # def __init__(self, *, flags_configuration: bytes, bandits_configuration: bytes | None = None) -> None: ... |
There was a problem hiding this comment.
It actually already has this signature, so no need to wait for v5:
https://github.com/Eppo-exp/rust-sdk/blob/427fed8fd54f3bdc7b69a9f2e198a72ef5ba4779/python-sdk/src/configuration.rs#L22
| "flags": {} | ||
| }).encode('utf-8') | ||
|
|
||
| FLAGS_CONFIG_WITH_BANDITS = ufc_with_bandits = json.dumps({ |
There was a problem hiding this comment.
double-assignment here is confusing
rasendubi
approved these changes
Oct 15, 2024
|
Just to clarify what's happening here, it's not that "configuration wrapper" didn't have the necessary parameter — it's just typing information that was out-of-sync ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Internal eppo ticket:
FF-3390Observation
When using Python on version
4.0.1(latest), unable to initialization bandit configuration from external payload.👉 Only bandit keys that have a corresponding key in the model configuration are available in the
get_bandit_keysfunction.Changes
sdk-test-datasubmodule to latest.