chore: clarify release process #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help with visibility as tags have much less information and are less visible.
|
|
||
| To release a new version of SDK: | ||
| 1. Make sure that version strings have been updated: | ||
| - Eppo core: [eppo_core/Cargo.toml](eppo_core/Cargo.toml) |
There was a problem hiding this comment.
My understanding is this should be treated with its own semver tree; for example breaking changes in eppo core might not be breaking changes up stream?
There was a problem hiding this comment.
Yes, all components have independent versioning
sameerank
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thank you! I would also appreciate more notes on local env setup (in a future PR is fine), e.g.
- what do I need to do before I run
npm run with-server test:pythonto see passing tests? - can I create a distribution package for python to install locally and try out before publishing to pypi?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a small incident with
[email protected]tag pushed without updating the version strings so it tried to publish new artifacts into already released[email protected]on pypi. Luckily, none of artifacts were actually pushed because they already exist.This incident went somewhat unnoticed because there were no GitHub release, just a tag. So I only noticed this when trying to push a new release and found that the tag already exists.
I have rectified this by deleting the old
[email protected]tag that did not have effect and created a proper release.This PR is a follow-up and: