fix: flatten "base" in AssignmentEvent #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
force-pushed
the
fix-flatten-base
branch
from
092a5b1 to
606b372
Compare
rasendubi
commented
Oct 16, 2024
| @@ -38,6 +38,7 @@ pub struct AssignmentEventBase { | |||
| #[derive(Debug, Clone, Serialize)] | |||
| #[serde(rename_all = "camelCase")] | |||
| pub struct AssignmentEvent { | |||
| #[serde(flatten)] | |||
There was a problem hiding this comment.
"flatten" unpacks a nested structure into parent when serializing
| ) | ||
| assert result == "partial-example" | ||
|
|
||
| assert event["allocation"] == "partial-example" |
There was a problem hiding this comment.
Does this demonstrate that nested elements, like base are no longer present?
There was a problem hiding this comment.
yes. the test fails without the flatten tag
leoromanovsky
approved these changes
Oct 16, 2024
felipecsl
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.