fix(ruby): Require shared lib from correct subdir #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
approved these changes
Oct 22, 2024
| * Run `cargo update --workspace --verbose` to update `Cargo.lock` and `Gemfile.lock`. | ||
| * Bump versions in `ruby-sdk/lib/eppo_client/version.rb` and `ruby-sdk/ext/eppo_client/Cargo.toml` | ||
| * Run `cargo update --workspace --verbose` to update `Cargo.lock` | ||
| * Run `bundle` to update `Gemfile.lock` |
There was a problem hiding this comment.
The developer needs to do this and check on it?
There was a problem hiding this comment.
correct. right now these are manual steps but we can certainly automate this in the future
The new |
|
Looks like it did indeed fail https://github.com/Eppo-exp/rust-sdk/actions/runs/11456821053/job/31875784240 but looks like a false negative, just forgot to add quotes around the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake-compiler puts the shared lib in a subdirectory of
eppo_clientwhen we build with multiple ruby target versions, so we need to load the lib from the correct subdir.Again, shamelessly stolen from wasmtime.
Also fixed the CI step so it runs properly (it wasnt)