-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generate rust-sdk github action with build.rs #67
Conversation
67b958d
to
a1ac5de
Compare
@@ -21,3 +21,8 @@ name = "simple" | |||
[dev-dependencies] | |||
chrono = "0.4.38" | |||
env_logger = { version = "0.11.3", features = ["unstable-kv"] } | |||
|
|||
[build-dependencies] | |||
gh-workflow = "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ A dependency in this package has a MSRV of 1.75
which blocks us from using it: JelteF/derive_more#389
I will fiddle around with it to see if we can overcome the blocker.
I'm actually not a fan of this approach. It might be cool but it doesn't seem to solve any real issue:
and adds a few new:
|
Observation
Desired behavior
Changes proposed
Use the
gh_workflow
crate inbuild.rs
to automatically keep the github workflow files updated.Rust's buildscripts (https://doc.rust-lang.org/cargo/reference/build-scripts.html) run on compilation; this PR generates no new work for developers.
Testing
ci.yml
file should be functionally equivalent