Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade deprecated macos-12 builds to macos-latest #77

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

leoromanovsky
Copy link
Member

@leoromanovsky leoromanovsky commented Nov 25, 2024

Observation

macos-12 runner is deprecated and has stopped working:

Screenshot 2024-11-25 at 3 19 39 PM

Changes

Bumped to macos-13 for x86_64 and restored aarch64 build on macos-14

@leoromanovsky leoromanovsky marked this pull request as ready for review November 26, 2024 06:11
.github/workflows/python.yml Outdated Show resolved Hide resolved
.github/workflows/python.yml Outdated Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
@rasendubi
Copy link
Collaborator

Looks like the new images added python-3.13 and we fail to build for that. To support it, it looks like we need to upgrade pyo3 to 0.23+ but we're held back by serde-pyobject which requires pyo3-0.22. I have submitted a PR here: Jij-Inc/serde-pyobject#13 and here's a fix for our repo: #79

@leoromanovsky
Copy link
Member Author

Looks like the new images added python-3.13 and we fail to build for that. To support it, it looks like we need to upgrade pyo3 to 0.23+ but we're held back by serde-pyobject which requires pyo3-0.22. I have submitted a PR here: Jij-Inc/serde-pyobject#13 and here's a fix for our repo: #79

Rebase with your latest changes ✔️

Run ls -l dist
total 13672
-rw-r--r--  1 runner  staff  2335283 Nov 27 [17](https://github.com/Eppo-exp/eppo-multiplatform/actions/runs/12054913678/job/33614056238?pr=77#step:5:18):01 eppo_server_sdk-4.1.1-cp311-cp311-macosx_10_12_x86_64.whl
-rw-r--r--  1 runner  staff  2329177 Nov 27 17:02 eppo_server_sdk-4.1.1-cp312-cp312-macosx_10_12_x86_64.whl
-rw-r--r--  1 runner  staff  2328976 Nov 27 17:03 eppo_server_sdk-4.1.1-cp313-cp313-macosx_10_12_x86_64.whl

@leoromanovsky leoromanovsky merged commit f5e770e into main Nov 27, 2024
26 checks passed
@leoromanovsky leoromanovsky deleted the lr/rm-dep branch November 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants