-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add test status badge to README #78
Conversation
README.md
Outdated
@@ -1,5 +1,10 @@ | |||
## Eppo Multiplatform: SDKs and Artifacts to support Flagging and Experimentation | |||
|
|||
[](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml) | |
[](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml) |
[](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml) | |
[](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml) |
ci.yml
is technically compiling all rust-code (except for fastly-edge-assignments
) but for clarity it could be renamed to rust.yml
. I am splitting out the fastly-edge-assignments
build in #75 and will look for a more elegant want to compose that file without the exclusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the work to split them out!
Made the change to the text here, but from what I can gather, it's actually pulling the name from the yaml file. I've updated the name in the yaml file, but since the badge is pulling the status from main
, it will still say "Test" until we merge here.
Co-authored-by: Leo Romanovsky <[email protected]>
@@ -1,4 +1,4 @@ | |||
name: Test | |||
name: Rust SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also handles testing the core and (currently) fastly, so it's not "rust sdk"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the discussion in the other thread. I think it's OK to merge but we should address this later
No description provided.