Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test status badge to README #78

Merged
merged 4 commits into from
Dec 2, 2024
Merged

feat: Add test status badge to README #78

merged 4 commits into from
Dec 2, 2024

Conversation

typotter
Copy link
Collaborator

No description provided.

README.md Outdated
@@ -1,5 +1,10 @@
## Eppo Multiplatform: SDKs and Artifacts to support Flagging and Experimentation

[![Test](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml/badge.svg)](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[![Test](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml/badge.svg)](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml)
[![Rust SDK](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml/badge.svg)](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml)
Suggested change
[![Test](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml/badge.svg)](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml)
[![Rust SDK](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml/badge.svg)](https://github.com/Eppo-exp/eppo-multiplatform/actions/workflows/ci.yml)

ci.yml is technically compiling all rust-code (except for fastly-edge-assignments) but for clarity it could be renamed to rust.yml. I am splitting out the fastly-edge-assignments build in #75 and will look for a more elegant want to compose that file without the exclusion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the work to split them out!

Made the change to the text here, but from what I can gather, it's actually pulling the name from the yaml file. I've updated the name in the yaml file, but since the badge is pulling the status from main, it will still say "Test" until we merge here.

@@ -1,4 +1,4 @@
name: Test
name: Rust SDK
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also handles testing the core and (currently) fastly, so it's not "rust sdk"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the discussion in the other thread. I think it's OK to merge but we should address this later

@rasendubi rasendubi merged commit a0c4741 into main Dec 2, 2024
26 checks passed
@rasendubi rasendubi deleted the tp/badge branch December 2, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants