Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): Redeliver subset of failed events from a batch #176

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat(events): Redeliver subset of failed events from a batch #176

merged 3 commits into from
Dec 12, 2024

Conversation

felipecsl
Copy link
Member

@felipecsl felipecsl commented Dec 11, 2024 •
edited
Loading

labels: mergeable

Fixes: FF-3686

Motivation and Context

Event ingestion API returns an array of event UUIDs that failed delivery.
Re-enqueue those for delivery.

Description

  • Parse the response body from the event ingestion URL
  • Find any UUIDs that failed delivery and re-enqueue for retry
  • Also take into account failed UUIDs when handling retries

How has this been tested?

Wrote tests

@felipecsl felipecsl requested a review from petzel December 11, 2024 21:26
@felipecsl felipecsl merged commit ccffe56 into main Dec 12, 2024
8 checks passed
@felipecsl felipecsl deleted the felipecsl--failed-uuids branch December 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petzel petzel petzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipecsl @petzel