-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF-1749: JS SDK Common UFC update #45
Merged
Merged
Changes from 10 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
f69cdc6
wip
schmit 07b9cde
making progress
schmit fd04b4b
make more tests pass
schmit ca7ea07
wip
schmit 2a7b3ec
fix more tests
schmit d676f4c
update event cache test
schmit 12eb7d1
.bind(this)
schmit e9bb4b3
pass all the tests
schmit 684da8a
Update script to create obfuscated UFC
schmit aa64366
add obfuscation and make all tests pass
schmit 4d6264e
cleanup
schmit 1e9e10e
Address PR comments
schmit cab5b1f
Address PR comments
schmit e5d4be1
Hardcoded obfuscation tests and other fixes
schmit 7400ed0
test for overwriting id for matching rules
schmit 4d9a3a0
remove unused import
schmit 67f7cbc
remove unneeded lint comment
schmit c6b0960
Add comment on getAssignmentDetail
schmit d71727e
addressing PR comments
schmit c650af5
update e2e test for more clarity
schmit bfd47f6
move obfuscated to client attribute, valueOf eppoValue
schmit bfc201e
add version metadata, add isInitialized
schmit 8e5dbeb
Add uninitialized test back in
schmit 7a3f392
add version update to pre-commit
schmit 25d8ebf
add version in pre-commit
schmit 834606e
test
schmit 370d80a
update version
schmit d058c46
bump version
schmit 9ce18fb
Merge branch 'main' into ufc-revamp
schmit cf991bc
dont be fancy
schmit 6d063c4
remove evaluator as arg to eppo client constructor
schmit a5cfe95
Replace lru-cache package with simple local implementation (FF-1876) …
leoromanovsky bafd881
Merge branch 'main' into ufc-revamp
schmit 5958d19
update endpoint to match backend
schmit ee3d43a
[ufc] add null operator and more fixes (#50)
schmit 9915183
export test helpers
schmit fd6e357
export flag and variationtype
schmit a28e473
export attribute type
schmit 08e36c8
export more types
schmit 7735cc6
Update function signatures
schmit 7b25f18
[UFC] Update obfuscation decoding (#52)
schmit 555dece
Merge branch 'main' into ufc-revamp
schmit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would a (logged) assigned variation be
null
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When no allocation matches (or when the flag is disabled) and we return
noneResult
. Is the question that you don't expect such occurrenced to be logged?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is to enable logging the lack of assignment, which seems valuable especially because you probably want to figure out why assignments are not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense if its a change we want. Note that currently, when no assignment is given, we do not log the null assignment.