Replace lru-cache package with simple local implementation (FF-1876) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
force-pushed
the
lr/ff-1876/lru-cache
branch
from
20b7543 to
0a8abda
Compare
leoromanovsky
force-pushed
the
lr/ff-1876/lru-cache
branch
from
0a8abda to
e45b813
Compare
aarsilv
approved these changes
Apr 5, 2024
| @@ -0,0 +1,64 @@ | |||
| import { LRUCache } from './lru-cache'; | |||
|
|
|||
| describe('LRUCache', () => { | |||
Comment on lines
+30
to
+34
| // the delete and set operations are used together to ensure that the most recently accessed | ||
| // or added item is always considered the "newest" in terms of access order. | ||
| // This is crucial for maintaining the correct order of elements in the cache, | ||
| // which directly impacts which item is considered the least recently used (LRU) and | ||
| // thus eligible for eviction when the cache reaches its capacity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
A customer is unable to upgrade eppo's latest js sdk versions.
The
lru-cachepackage appears to be incompatible for some reason.Description
Replaces the package with a simple local implementation. Are needs do not require generic types, just a
Map<string, string>suffices.How has this been tested?
New unit test for
LRUCacheclass.