[ufc] add null operator and more fixes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmit
commented
Apr 15, 2024
Comment on lines
+14
to
+24
| function encodeRuleValue(condition: Condition) { | ||
| switch (condition.operator) { | ||
| case 'ONE_OF': | ||
| case 'NOT_ONE_OF': | ||
| return condition.value.map((value) => getMD5Hash(value.toLowerCase())); | ||
| case 'IS_NULL': | ||
| return getMD5Hash(`${condition.value}`); | ||
| default: | ||
| return encodeBase64(`${condition.value}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
@aarsilv heads-up: adding extra logic here to handle the IS_NULL operator
schmit
changed the title
giorgiomartini0
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Description
How has this been tested?