Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix nodejs failing to start #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bug: fix nodejs failing to start #117

wants to merge 2 commits into from
+4 −4

Conversation

leoromanovsky
Copy link
Member

@leoromanovsky leoromanovsky commented Feb 27, 2025 •
edited
Loading

observation

1️⃣ nodejs relay server is failing to start:

yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > [email protected]" has unmet peer dependency "webpack@^5.0.0".
[4/4] Building fresh packages...
Done in 12.49s.
Listening on port 4000
yarn run v1.22.22
$ node dist/main
node:internal/modules/cjs/loader:1228
  throw err;
  ^

Error: Cannot find module '/home/runner/work/sdk-test-data/sdk-test-data/package-testing/node-sdk-relay/dist/main'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v20.18.3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

2️⃣ after nodejs start working, I see that almost all bandit tests are failing

158/188 passed
30 failures
Test results written to logs/results.xml

description

  • perform a production build before starting - nodejs server starts up
  • todo: fix bandit tests

@leoromanovsky leoromanovsky marked this pull request as ready for review February 27, 2025 02:10
typotter
typotter approved these changes Mar 5, 2025
View reviewed changes
package-testing/node-sdk-relay/build-and-run.sh
@@ -8,5 +8,7 @@ SDK="https://github.com/Eppo-exp/node-server-sdk.git"

# Run the poller
yarn install
# Build the application
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠

package-testing/node-sdk-relay/src/app.controller.ts
@@ -43,7 +43,7 @@ export class AppController {
const currentInstance = getInstance();
currentInstance.stopPolling();
await init({
apiKey: 'test',
apiKey: process.env.EPPO_API_KEY || 'NOKEYSPECIFIED',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typotter typotter typotter approved these changes

@aarsilv aarsilv Awaiting requested review from aarsilv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoromanovsky @typotter