[FF-4069] Update plain and obfuscated configs for flags for variation of type STRING with special characters in values #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgdreamer7
requested review from
greghuels,
leoromanovsky,
aarsilv,
typotter,
sameerank and
MagicMarka
typotter
reviewed
Mar 4, 2025
| @@ -1355,6 +1355,1799 @@ | |||
| "doLog": false | |||
| } | |||
| ] | |||
| }, | |||
typotter
approved these changes
Mar 4, 2025
| @@ -0,0 +1,98 @@ | |||
| export interface ITargetingRuleCondition { | |||
There was a problem hiding this comment.
Would it be useful to get these types from the Eppo js-common-sdk package?
There was a problem hiding this comment.
It would be nice. But I couldn't find them in https://github.com/Eppo-exp/js-sdk-common.
| import { obfuscateUniversalFlagConfig } from "./obfuscation.helper"; | ||
| import { UniversalFlagConfig } from "./ufc.dto"; | ||
|
|
||
| describe('Obfuscate UFC config', () => { |
Sure, I will add/updated README in this PR. |
|
I think @typotter knows this repo the best, so if he approves, you are good to go. |
Readme updated here b18b1d1. |
sgdreamer7
deleted the
vlod/ff-4069-adjust-shared-sdk-test-data-to-ensure-sdks-can-handle-non
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eppo Internal:
🎟️ Ticket: FF-4069 - Adjust Shared SDK Test Data to Ensure SDKs can handle non-alphanumeric characters in String values
Description:
SDKs need to be able to handle special characters in values for the variations of type STRING. This PR adds a test cases to check all possible allowed special characters as values of the variations. Test cases cover single inclusion of special character, multiple special characters divided by regular ones, multiple repeating special characters as a whole variation value.