Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metal sdpa for v stride #905

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Fix metal sdpa for v stride #905

merged 2 commits into from
Nov 10, 2024

Conversation

EricLBuehler
Copy link
Owner

Doesn't look like we suffered any actual effects as k,v are both contiguous. However, this is a nice fix.

Copy link

Code Metrics Report
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 C Header                2           35           28            0            7
 Dockerfile              1           41           22           10            9
 Happy                   1          442          369            0           73
 JSON                   12          105          104            0            1
 Python                 53         2274         1949           63          262
 Shell                   1           57           22           18           17
 TOML                   18          579          516            2           61
 YAML                    2           21           19            2            0
-------------------------------------------------------------------------------
 Jupyter Notebooks       4            0            0            0            0
 |- Markdown             2           77           32           31           14
 |- Python               2          196          169            1           26
 (Total)                            273          201           32           40
-------------------------------------------------------------------------------
 Markdown               40         3009            0         2286          723
 |- BASH                 6          101           98            0            3
 |- JSON                 1           12           12            0            0
 |- Python               6          114          102            0           12
 |- Rust                10          361          306            0           55
 |- TOML                 2           75           63            0           12
 (Total)                           3672          581         2286          805
-------------------------------------------------------------------------------
 Rust                  278        83063        74547         1742         6774
 |- Markdown           134         1413           25         1285          103
 (Total)                          84476        74572         3027         6877
===============================================================================
 Total                 413        89626        77576         4123         7927
===============================================================================
  

@EricLBuehler EricLBuehler merged commit 84a66b9 into master Nov 10, 2024
12 checks passed
@EricLBuehler EricLBuehler deleted the fix_metal_sdpa_vstride branch November 10, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant