Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): workaround for missing nvidia-smi, bump cuda to current #913

Closed
wants to merge 0 commits into from

Conversation

sammcj
Copy link

@sammcj sammcj commented Nov 16, 2024

I can very rarely seem to get MistralRS to build successfully (using the stock Dockerfiles/instructions) so please test this before merging, hence raising this as a draft.

Copy link

github-actions bot commented Nov 16, 2024

Code Metrics Report
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 C Header                2           35           28            0            7
 Dockerfile              1           41           22           10            9
 Happy                   1          442          369            0           73
 JSON                   12          105          104            0            1
 Python                 53         2274         1949           63          262
 Shell                   1           57           22           18           17
 TOML                   18          583          520            2           61
 YAML                    2           21           19            2            0
-------------------------------------------------------------------------------
 Jupyter Notebooks       4            0            0            0            0
 |- Markdown             2           77           32           31           14
 |- Python               2          196          169            1           26
 (Total)                            273          201           32           40
-------------------------------------------------------------------------------
 Markdown               40         3009            0         2286          723
 |- BASH                 6          101           98            0            3
 |- JSON                 1           12           12            0            0
 |- Python               6          114          102            0           12
 |- Rust                10          361          306            0           55
 |- TOML                 2           75           63            0           12
 (Total)                           3672          581         2286          805
-------------------------------------------------------------------------------
 Rust                  280        84867        76145         1762         6960
 |- Markdown           136         1435           25         1306          104
 (Total)                          86302        76170         3068         7064
===============================================================================
 Total                 415        91434        79178         4143         8113
===============================================================================
  

@EricLBuehler
Copy link
Owner

@sammcj it seems the changes for this PR are gone? Please let me know when this is ready to review!

@sammcj
Copy link
Author

sammcj commented Nov 19, 2024

it seems the changes for this PR are gone?

What on earth!

@sammcj
Copy link
Author

sammcj commented Nov 19, 2024

I honestly have no idea what's happened with Git/Github here, I checked my local repo and it had the commit with the changes so I tried to push again and it said I to pull first - which I thought was weird as it was my fork, did it anyway - then my changes and commit disappeared locally!

Very weird. Perhaps when I have time I'll do it again. :(

@sammcj sammcj closed this Nov 19, 2024
@EricLBuehler
Copy link
Owner

@sammcj if you have the time to recreate the PR that would be great!

@EricLBuehler
Copy link
Owner

6390436

@sammcj
Copy link
Author

sammcj commented Nov 20, 2024

Oh wow

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

How did you find it out of interest?

@EricLBuehler
Copy link
Owner

It looks like the pull bot force pushed, and GH shows what commit it pushed from:
Screenshot 2024-11-19 at 8 41 00 PM

@sammcj
Copy link
Author

sammcj commented Nov 20, 2024

Far out - good spotting!

@sammcj
Copy link
Author

sammcj commented Nov 20, 2024

Key takeaway for me on that is to make sure any PRs I submit are created on a non-default branch on my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants