Removal of commented sections #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLBuehler
commented
Feb 21, 2024
| @@ -137,8 +137,8 @@ def hook(module, *args, **kwargs) -> None: | |||
|
|
|||
| model_peft.internal_xlora_scalings = torch.full( # type: ignore | |||
| (payload.batch_size, payload.seq_len, xlora_classifier.n_layers, xlora_classifier.n_classes), | |||
| payload.override_scaling_pass_value, # requires_grad=True | |||
There was a problem hiding this comment.
Commented and unused.
| @@ -139,14 +139,6 @@ def forward( | |||
| model: PeftModel = self.model # type: ignore | |||
| with torch.no_grad(): | |||
| with model.disable_adapter(): | |||
| # TODO(EricLBuehler): Pending removal following analysis | |||
| hidden_states = result.hidden_states # type: ignore | ||
|
|
||
| assert hidden_states is not None | ||
| hidden_state = hidden_states[-1] # Get the last hidden state | ||
|
|
||
| ### Calculate the sequence lengths |
There was a problem hiding this comment.
Changed method to use all tokens
| @@ -20,7 +20,7 @@ class xLoRALayer: | |||
| xLoRA algorithm. | |||
| """ | |||
|
|
|||
| __slots__ = {"model", "target_forward", "target", "layer_number", "disabled", "config"} | |||
EricLBuehler
added a commit
to EricLBuehler/peft
that referenced
this pull request
Feb 21, 2024
EricLBuehler
added a commit
to EricLBuehler/peft
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all, inert, commented sections of code.