Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Javascript.json/Modified the body #36

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Updated Javascript.json/Modified the body #36

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5fcdbe
Modified the body
Priyanshu-bit Sep 27, 2023
41a0d37
Update javascript.json/CreateMap
Priyanshu-bit Oct 17, 2023
d185a13
Update javascript.json
Priyanshu-bit Oct 17, 2023
5f3523e
Update javascript.json
Priyanshu-bit Oct 19, 2023
60fdf08
Refactor and docs
hhkaos Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions snippets/javascript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,11 @@
},
"CreateMap": {
"body": [
"const map = new Map({",
"new Map({",
"\tbasemap: \"${1|arcgis-imagery,arcgis-imagery-standard,arcgis-imagery-labels,arcgis-light-gray,arcgis-dark-gray,arcgis-navigation,arcgis-navigation-night,arcgis-streets,arcgis-streets-night,arcgis-streets-relief,arcgis-topographic,arcgis-oceans,osm-standard,osm-standard-relief,osm-streets,osm-streets-relief,osm-light-gray,osm-dark-gray,arcgis-terrain,arcgis-community,arcgis-charted-territory,arcgis-colored-pencil,arcgis-nova,arcgis-modern-antique,arcgis-midcentury,arcgis-newspaper,arcgis-hillshade-light,arcgis-hillshade-dark|}\"",
"});",
"const view = new MapView({",

"new MapView({",
"\tcontainer:${2:\"viewDiv\"},",
"\tmap:map,",
"\tzoom: ${3: 4},",
Expand All @@ -102,10 +103,10 @@
},
"CreateScene": {
"body": [
"const map = new Map({",
"new Map({",
"\tbasemap: \"${1:streets}\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we have a snippet basemapStyle. I think it would make sense to place it, same with "Create map". What to do think? I will be easier to maintain.

We also have the problem with autocasting below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autocasting done, rest cannot understand properly

"});",
"const view = new SceneView({",
"new SceneView({",
"\tcontainer: \"${2:viewDiv}\",",
"\tmap:map",
"});"
Expand All @@ -115,12 +116,12 @@
},
"CreateWebMap": {
"body": [
"const webmap = new WebMap({",
"new WebMap({",
Priyanshu-bit marked this conversation as resolved.
Show resolved Hide resolved
"\tportalItem: {",
"\t\tid: \"${1:webmap_id}\"",
"\t}",
"});",
"const view = new MapView({",
"new MapView({",
"\tcontainer: \"${2:viewDiv}\",",
"\tmap: webmap",
"});"
Expand All @@ -130,12 +131,12 @@
},
"CreateWebScene": {
"body": [
"const webscene = new WebScene({",
"new WebScene({",
"\tportalItem: {",
"\t\tid: \"${1:webscene_id}\"",
"\t}",
"});",
"const view = new SceneView({",
"new SceneView({",
"\tcontainer: \"${2:viewDiv}\",",
"\tmap: webscene",
"});"
Expand Down