Using and updating GIS content sample notebook revamped according to the new map widget

[tarunkukreja003]

Using and updating GIS content sample notebook is now revamped according to the new map widget

Major changes include:

1. The JSON of the web scene or web map is not changed anymore, instead, we use property setters to update the web maps and web scenes
2. Properties and methods updated according to the new map widget

NOTE
PLEASE TEST AGAINST THIS PR https://github.com/ArcGIS/geoserpent/pull/190, THE NOTEBOOK CELLS WILL ONLY WORK IF THE CHANGES FROM THIS PR IS PULLED IN

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:01Z
----------------------------------------------------------------

• If you want to de-capitalize ArcGIS in the second sentence then I would suggest:

'The arcgis package includes several classes to make use of this content'

• Also it was correct with this content. If you want to use 'these' then make content plural: these contents

• Unnecessary 'the' added before them. Please remove.

Suggested full second sentence:

"The arcgis package includes several classes to make use of this content, publish new items and update them when needed."

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:02Z
----------------------------------------------------------------

Not sure if this is just in notebook reviewer but the table of contents looks super spread out

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:03Z
----------------------------------------------------------------

This seems to not be needed

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:04Z
----------------------------------------------------------------

If you are going to add this logic, add a description of what you are doing. This is not intuitive to new users

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:04Z
----------------------------------------------------------------

Map(item=wm_item)

The first parameter is location. Although there is a check in place let's promote best practice in samples

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:05Z
----------------------------------------------------------------

Add back this comment above this cell:

The web map was sucessfully overwritten with correct operational layers. You can interact with the widget and zoom into the USA to observe the locations of capitals.

Then inside the cell add back this comment:

# Let's clean it up so we can always run this notebook again

This way users know why we are deleting everything

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:06Z
----------------------------------------------------------------

Why don't you delete the layers instead? I don't think we want to encourage overwriting the layers property since this is not a documented workflow.

Use: map.content.delete(<layer_index>)

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:07Z
----------------------------------------------------------------

Layers property should not be set

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:08Z
----------------------------------------------------------------

There is a property for Scene called basemaps3d . It would be cool to use one of those since scene is trying to promote using them.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-11-13T08:56:09Z
----------------------------------------------------------------

Add a comment how using the save method will create a new Scene or Map in portal whereas the update method we used above will update the changes to the existing Map.

[nanaeaubry]

Left some comments in the notebook reviewer. Good start with this! :)