-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(block): heading text color #11314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
Issues tied to code that needs to be significantly reworked.
label
Jan 15, 2025
Elijbet
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Jan 15, 2025
Elijbet
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Jan 16, 2025
alisonailea
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! LGTM
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Jan 16, 2025
benelan
added a commit
that referenced
this pull request
Jan 21, 2025
* origin/dev: (322 commits) chore: add ui icons package to enhancement template (#11344) chore(table): move workaround comment back to its usage (#11341) ci(actions): refine remove-issue-from-design-projects workflow (#11325) chore(actions): add icon leads notification for calcite-ui-icons requests (#11263) test(combobox): use async expect for non-throwing test case (#11332) fix(combobox, input-time-zone): fix initial item selection delay (#11326) build(deps): update dependency type-fest to v4.32.0 (#11308) chore(utility-network-layer, crosshair): add font codepoints (#11336) refactor(loadable): deprecate obsolete helpers (#11312) chore: release next feat: add crosshair (#11331) build(deps): update arcgis to ^4.32.0-next.81 (#11273) ci(actions): add action to remove issues from design projects (#11249) chore: release next fix(list-item): reflect the sortHandleOpen property (#11323) refactor(block): heading text color (#11314) chore: release next fix(list): only focus on row when clicking a list item (#11310) fix(tooltip, popover): honor prevented events (#11278) chore: release next ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
refactor
Issues tied to code that needs to be significantly reworked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Refactor block heading text color.
open/close
icon shares a hover state with the color of the heading text when the component is open.Adds the following component token:
--calcite-block-heading-text-color-press