Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(block): heading text color #11314

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jan 15, 2025

Related Issue: #7180

Summary

Refactor block heading text color. open/close icon shares a hover state with the color of the heading text when the component is open.

Adds the following component token:

--calcite-block-heading-text-color-press

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 15, 2025
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 15, 2025
@Elijbet Elijbet marked this pull request as ready for review January 16, 2025 00:26
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 16, 2025
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM

@Elijbet Elijbet merged commit 4dde26f into dev Jan 16, 2025
15 checks passed
@Elijbet Elijbet deleted the elijbet/7180-block-heading-text-color branch January 16, 2025 18:09
benelan added a commit that referenced this pull request Jan 21, 2025
* origin/dev: (322 commits)
  chore: add ui icons package to enhancement template (#11344)
  chore(table): move workaround comment back to its usage (#11341)
  ci(actions): refine remove-issue-from-design-projects workflow (#11325)
  chore(actions): add icon leads notification for calcite-ui-icons requests (#11263)
  test(combobox): use async expect for non-throwing test case (#11332)
  fix(combobox, input-time-zone): fix initial item selection delay (#11326)
  build(deps): update dependency type-fest to v4.32.0 (#11308)
  chore(utility-network-layer, crosshair): add font codepoints (#11336)
  refactor(loadable): deprecate obsolete helpers (#11312)
  chore: release next
  feat: add crosshair (#11331)
  build(deps): update arcgis to ^4.32.0-next.81 (#11273)
  ci(actions): add action to remove issues from design projects (#11249)
  chore: release next
  fix(list-item): reflect the sortHandleOpen property (#11323)
  refactor(block): heading text color (#11314)
  chore: release next
  fix(list): only focus on row when clicking a list item (#11310)
  fix(tooltip, popover): honor prevented events (#11278)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants