Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: restore skipped tests #11570

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ describe("calcite-action-bar", () => {
expect(await findAll(page, slottedActionsSelector)).toHaveLength(7);
});

it.skip("should slot 'menu-actions' on resize of component", async () => {
it("should slot 'menu-actions' on resize of component", async () => {
const page = await newE2EPage({
html: html`<div style="width:500px; height:500px;">
<calcite-action-bar style="height: 290px">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ describe("calcite-color-picker-hex-input", () => {
input = await page.find("calcite-color-picker-hex-input");
});

it.skip("commits hexa chars on Tab and Enter", async () => {
it("commits hexa chars on Tab and Enter", async () => {
await assertTabAndEnterBehavior("b00", "#bb0000ff", true);
await assertTabAndEnterBehavior("abcd", "#aabbccdd", true);
// eslint-disable-next-line @cspell/spellchecker -- testing hex code
Expand All @@ -552,7 +552,7 @@ describe("calcite-color-picker-hex-input", () => {
await assertTabAndEnterBehavior("", startingHexa, true);
});

it.skip("prevents committing invalid hexa values", async () => {
it("prevents committing invalid hexa values", async () => {
// eslint-disable-next-line @cspell/spellchecker -- testing hex code
await assertTabAndEnterBehavior("aabbccd", startingHexa, true);
// eslint-disable-next-line @cspell/spellchecker -- testing hex code
Expand Down Expand Up @@ -597,7 +597,7 @@ describe("calcite-color-picker-hex-input", () => {
await page.waitForChanges();
});

it.skip("commits hexa chars on Tab and Enter", async () => {
it("commits hexa chars on Tab and Enter", async () => {
await assertTabAndEnterBehavior("b00", "#bb0000ff", true);
await assertTabAndEnterBehavior("baba", "#bbaabbaa", true);
// eslint-disable-next-line @cspell/spellchecker -- testing hex code
Expand All @@ -606,7 +606,7 @@ describe("calcite-color-picker-hex-input", () => {
await assertTabAndEnterBehavior("", null, true);
});

it.skip("prevents committing invalid hexa values", async () => {
it("prevents committing invalid hexa values", async () => {
// eslint-disable-next-line @cspell/spellchecker -- testing hex code
await assertTabAndEnterBehavior("aabbccd", startingHexa, true);
// eslint-disable-next-line @cspell/spellchecker -- testing hex code
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,15 @@ describe("calcite-combobox", () => {
hidden("calcite-combobox");
});

describe.skip("accessible", () => {
describe("accessible", () => {
accessible(html`
<calcite-combobox label="Trees" value="Trees">
<calcite-combobox-item value="Pine" text-label="Pine"></calcite-combobox-item>
</calcite-combobox>
`);
});

describe.skip("accessible with item group", () => {
describe("accessible with item group", () => {
accessible(html`
<calcite-combobox label="Trees" value="Trees">
<calcite-combobox-item-group label="Conifers">
Expand All @@ -157,7 +157,7 @@ describe("calcite-combobox", () => {
`);
});

describe.skip("accessible with open selected items", () => {
describe("accessible with open selected items", () => {
accessible(html`
<calcite-combobox open label="Trees" value="Trees">
<calcite-combobox-item-group label="Conifers">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ describe("calcite-input-number", () => {
});
});

describe.skip("increment/decrement functionality", () => {
describe("increment/decrement functionality", () => {
let page: E2EPage;
beforeEach(async () => {
page = await newE2EPage();
Expand Down Expand Up @@ -591,7 +591,7 @@ describe("calcite-input-number", () => {
buttonUpLocation = [x, y];
});

it.skip("should emit an event regularly on mousedown", async () => {
it("should emit an event regularly on mousedown", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonUpLocation.x, buttonUpLocation.y);
await page.mouse.down();
Expand All @@ -602,7 +602,7 @@ describe("calcite-input-number", () => {
expect(await input.getProperty("value")).toBe(`${totalNudgesUp}`);
});

it.skip("should stop emitting an event on mouseleave", async () => {
it("should stop emitting an event on mouseleave", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonUpLocation.x, buttonUpLocation.y);
await page.mouse.down();
Expand All @@ -629,7 +629,7 @@ describe("calcite-input-number", () => {
buttonDownLocation = [x, y];
});

it.skip("should emit an event regularly on mousedown", async () => {
it("should emit an event regularly on mousedown", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonDownLocation.x, buttonDownLocation.y);
await page.mouse.down();
Expand All @@ -640,7 +640,7 @@ describe("calcite-input-number", () => {
expect(await input.getProperty("value")).toBe(`${totalNudgesUp}`);
});

it.skip("should stop emitting an event on mouseleave", async () => {
it("should stop emitting an event on mouseleave", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonDownLocation.x, buttonDownLocation.y);
await page.mouse.down();
Expand Down Expand Up @@ -1740,7 +1740,7 @@ describe("calcite-input-number", () => {
t9n("calcite-input-number");
});

it.skip("should stop increasing the value when pointer is moved away from the increment button", async () => {
it("should stop increasing the value when pointer is moved away from the increment button", async () => {
const page = await newE2EPage();
await page.setContent("<calcite-input-number></calcite-input-number>");
const inputNumber = await page.find("calcite-input-number");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ describe("calcite-input-text", () => {
expect(changeEventSpy).not.toHaveReceivedEvent();
});

it.skip("emits events when value is modified", async () => {
it("emits events when value is modified", async () => {
const page = await newE2EPage();
await page.setContent(html`<calcite-input-text></calcite-input-text>`);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe("calcite-input-time-picker", () => {
describe("openClose", () => {
openClose("calcite-input-time-picker");

describe.skip("initially open", () => {
describe("initially open", () => {
openClose.initial("calcite-input-time-picker");
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1975,7 +1975,7 @@ describe("calcite-list", () => {
});

describe("group filtering", () => {
it.skip("should include groups while filtering", async () => {
it("should include groups while filtering", async () => {
const page = await newE2EPage();
await page.setContent(html`
<calcite-list filter-enabled filter-placeholder="typing 'recreation' should show 1st group with all items">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ describe("calcite-radio-button", () => {
expect(blurEvent).toHaveReceivedEventTimes(1);
});

it.skip("appropriately triggers the custom internal focus and blur events with keyboard", async () => {
it("appropriately triggers the custom internal focus and blur events with keyboard", async () => {
const page = await newE2EPage();
await page.setContent(
`<calcite-radio-button name="example"></calcite-radio-button><calcite-radio-button name="example"></calcite-radio-button>`,
Expand Down Expand Up @@ -602,7 +602,7 @@ describe("calcite-radio-button", () => {

// skipped until the util supports a parent component wrapping the form associated element(s)
// https://github.com/Esri/calcite-design-system/issues/9221
describe.skip("group", () => {
describe("group", () => {
formAssociated(
html`
<calcite-radio-button-group name="using" required>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ describe("calcite-slider", () => {

// skipped due to a bug where value is rounded down instead of up:
// https://github.com/Esri/calcite-design-system/issues/9684
it.skip("step floating point precision", async () => {
it("step floating point precision", async () => {
const page = await newE2EPage();
await page.setContent(
html`<calcite-slider value="1.4" label-handles max="10" min="0.1" snap step="0.1"></calcite-slider>`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ describe("calcite-stepper", () => {
}
});

describe.skip("honors hidden attribute", () => {
describe("honors hidden attribute", () => {
hidden("calcite-stepper");
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { describe, it } from "vitest";
// TODO: Uncomment this test when there's a resolution to this bug. https://github.com/ionic-team/stencil/issues/1669
// import { TipManager } from "./calcite-tip-manager";

describe.skip("TipManager", () => {
describe("TipManager", () => {
it("should increment/decrement the selectedIndex when the public next/prev methods are called", () => {
// const tipManager = new TipManager();
// tipManager.total = 2; //needed to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ describe("calcite-tooltip", () => {
});
});

it.skip("should open hovered tooltip while pointer is moving", async () => {
it("should open hovered tooltip while pointer is moving", async () => {
const page = await newE2EPage();
await page.setContent(html`
<calcite-tooltip reference-element="ref">Content</calcite-tooltip>
Expand Down Expand Up @@ -1090,7 +1090,7 @@ describe("calcite-tooltip", () => {
}
});

it.skip("should close non hovered tooltip while pointer is moving", async () => {
it("should close non hovered tooltip while pointer is moving", async () => {
const page = await newE2EPage();
await page.setContent(html`
<calcite-tooltip reference-element="ref">Content</calcite-tooltip>
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/utils/floating-ui.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ describe("repositioning", () => {
assertOpenPositioning(floatingEl);
});

it.skip("debounces positioning per instance", async () => {
it("debounces positioning per instance", async () => {
const positionSpy = vi.spyOn(floatingUI, "positionFloatingUI");
fakeFloatingUiComponent.open = true;

Expand Down
Loading