-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add displayConfig in Hub Catalog, update GalleryDisplayConfigSchema #1747
Open
vivzhang
wants to merge
15
commits into
master
Choose a base branch
from
f/11582-catalog-results-appearance-configuration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−2
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5d5cd00
feat: add displayConfig in Hub Catalog, update GalleryDisplayConfigSc…
vivzhang f5ed6a8
Merge branch 'master' into f/11582-catalog-results-appearance-configu…
vivzhang 60cdcfe
test: add tests and comment
vivzhang 27cd6e1
Merge branch 'f/11582-catalog-results-appearance-configuration' of ht…
vivzhang bd98b34
refactor: make props optional in IGalleryDisplayConfig
vivzhang 2dfd748
Merge branch 'master' into f/11582-catalog-results-appearance-configu…
vivzhang ef1986d
refactor: expand layout in IGalleryDisplayConfig and add comments
vivzhang 594b0c6
Merge branch 'f/11582-catalog-results-appearance-configuration' of ht…
vivzhang 5fe3331
refactor: add compact layout to GalleryDisplayConfigSchema
vivzhang 8860e93
Merge branch 'master' into f/11582-catalog-results-appearance-configu…
vivzhang e3f3126
refactor: use enum for some GalleryDisplayConfigSchema types
vivzhang 09a7eb3
refactor: update schema enums
vivzhang f953c2c
refactor: revert some schema enums
vivzhang 4f900d6
Merge branch 'master' into f/11582-catalog-results-appearance-configu…
vivzhang 82047c2
test: fix tests
vivzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow...should we be using this for the combobox/item type work then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we stick with our
getContentTypeIcon
for now for consistency. I added this comment here because I just got that info from the AGO team, it was new to me as well. I think this needs a holistic review by Design first before we decide what to do.