Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve circular deps related to ArcGISContext #1815

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

dbouwman
Copy link
Member

  1. Description:
  • extract types / interfaces from ArcGISContext and ArcGISContextManager files
  • fix all related imports and change them to be import type
  • fix all related test imports
  • this reduces the circular deps to 49 from 72
  1. Instructions for testing: run tests

  2. Closes Issues: n/a - just payin down some dept

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for switching to type imports

@dbouwman dbouwman force-pushed the f/fix-context-cyclic-deps branch from 6f157fe to c57d781 Compare February 26, 2025 18:51
@dbouwman dbouwman merged commit 05d8e4d into master Feb 26, 2025
5 checks passed
@dbouwman dbouwman deleted the f/fix-context-cyclic-deps branch February 26, 2025 21:10
esri-dcdev-2 pushed a commit that referenced this pull request Feb 26, 2025
## @esri/hub-initiatives [15.0.1](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-26)

### Bug Fixes

* resolve circular deps related to ArcGISContext ([#1815](#1815)) ([05d8e4d](05d8e4d))
esri-dcdev-2 pushed a commit that referenced this pull request Feb 26, 2025
## [15.37.1](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-26)

### Bug Fixes

* resolve circular deps related to ArcGISContext ([#1815](#1815)) ([05d8e4d](05d8e4d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants