Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WeakReference to store alternative commands #5572

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Use WeakReference to store alternative commands #5572

merged 2 commits into from
Nov 27, 2023

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Nov 11, 2023 •
edited
Loading

Fixes #5539

@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Nov 11, 2023
@JRoy JRoy added this to the 2.20.2 milestone Nov 11, 2023
@JRoy JRoy enabled auto-merge (squash) November 27, 2023 21:25
Evidentsinger14
Evidentsinger14 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Evidentsinger14 Evidentsinger14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JRoy JRoy merged commit bb7b334 into EssentialsX:2.x Nov 27, 2023
1 check passed
@JRoy JRoy deleted the fix/cmd-gc-woahs branch November 27, 2023 21:39
HarvelsX pushed a commit to HarvelsX/Essentials that referenced this pull request Jun 2, 2024
@JRoy @OOP-778 @HarvelsX
Use WeakReference to store alternative commands (EssentialsX#5572)
6d4c791 
Co-authored-by: oop778 <[email protected]>
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
@JRoy @OOP-778 @Starmism
Use WeakReference to store alternative commands (EssentialsX#5572)
d852023 
Co-authored-by: oop778 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evidentsinger14 Evidentsinger14 Evidentsinger14 approved these changes

@pop4959 pop4959 pop4959 approved these changes

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.20.2
Development

Successfully merging this pull request may close these issues.

AlternativeCommandsHandler is preventing commands from being gc'ed
3 participants
@JRoy @pop4959 @Evidentsinger14