Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/731/slim dayview #740

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feature/731/slim dayview #740

wants to merge 7 commits into from

Conversation

newhinton
Copy link
Contributor

No description provided.

@newhinton newhinton mentioned this pull request Jul 15, 2020
Open
@jspricke
Copy link
Member

Removing the bolding sounds ok to me (maybe we should increase the font size at the same time) but rounding the events seems to much. It makes the view nosy by doubling all the edges and some letters almost touch the edge.

@jspricke
Copy link
Member

Also, please don't change unrelated lines (whitespace changes..)

@newhinton
Merge remote-tracking branch 'etarcalendar/master' into feature/731/s…
081043d 
…lim_dayview

# Conflicts:
#	src/com/android/calendar/DayView.java
@newhinton
Copy link
Contributor Author

@jspricke Updating the upstream should also have cleared the whitespace issues. Any news if this is going to be merged?

@jspricke
Copy link
Member

As commented above, we will not pick up the rounding.

Btw. you should not merge master into a feature branch but maybe rebase if it makes sense.

@newhinton
Copy link
Contributor Author

example
Would this be better? A tiny radius still looks a bit more modern but does not interfere with the content

@newhinton
Copy link
Contributor Author

Any news on this? Especially with android 12 etar will have to make changes to it's userinterface, at least to it's widgets

@dumblob
Copy link

dumblob commented Nov 5, 2022

The new "mini" rounding looks very good to me. @jspricke wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhinton @jspricke @dumblob