add default arguement to add media node func (#9150)

* add defautl arguement to add media node func * fix check-errors errors --------- Co-authored-by: Josh Field <[email protected]>
EtherealEngine · Oct 28, 2023 · 689c87e · 689c87e
1 parent 8ebb6b1
commit 689c87e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -107,6 +107,7 @@
     "@types/cli": "0.11.21",
     "@types/mocha": "10.0.1",
     "@types/primus": "^7.3.6",
+    "@types/three": "0.157.0",
     "@typescript-eslint/eslint-plugin": "5.56.0",
     "@typescript-eslint/parser": "5.56.0",
     "concurrently": "7.6.0",

diff --git a/packages/editor/src/components/properties/ParticleSystemNodeEditor.tsx b/packages/editor/src/components/properties/ParticleSystemNodeEditor.tsx
@@ -251,7 +251,7 @@ const ParticleSystemNodeEditor: EditorComponentType = (props) => {
                 value={burst.probability.value}
                 onChange={onSetState(burst.probability)}
               />
-              <Button onClick={onRemoveBurst(burst)}>Remove Burst</Button>
+              <Button onClick={onRemoveBurst(burst as any)}>Remove Burst</Button>
             </div>
           )
         }}
@@ -329,7 +329,7 @@ const ParticleSystemNodeEditor: EditorComponentType = (props) => {
             <ValueGenerator
               value={particleSystem.systemParameters.rendererEmitterSettings.startLength as ValueGeneratorJSON}
               scope={
-                particleSystemState.systemParameters.rendererEmitterSettings
+                (particleSystemState.systemParameters.rendererEmitterSettings as any)
                   .startLength as unknown as State<ValueGeneratorJSON>
               }
               onChange={onSetState}

diff --git a/packages/editor/src/functions/addMediaNode.ts b/packages/editor/src/functions/addMediaNode.ts
@@ -33,6 +33,8 @@ import { VideoComponent } from '@etherealengine/engine/src/scene/components/Vide
 import { VolumetricComponent } from '@etherealengine/engine/src/scene/components/VolumetricComponent'
 
 import { ComponentJson } from '@etherealengine/common/src/interfaces/SceneInterface'
+import { SceneState } from '@etherealengine/engine/src/ecs/classes/Scene'
+import { getState } from '@etherealengine/hyperflux'
 import { EditorControlFunctions } from './EditorControlFunctions'
 
 /**
@@ -44,7 +46,7 @@ import { EditorControlFunctions } from './EditorControlFunctions'
  */
 export async function addMediaNode(
   url: string,
-  parent: Entity | null = null,
+  parent: Entity | null = getState(SceneState).sceneEntity,
   before: Entity | null = null,
   extraComponentJson: ComponentJson[] = []
 ) {

diff --git a/packages/editor/src/lightmapper/AutoUV2.tsx b/packages/editor/src/lightmapper/AutoUV2.tsx
@@ -85,7 +85,7 @@ function convertGeometryToIndexed(buffer: THREE.BufferGeometry) {
     groupIndexArray.fill(group.materialIndex, group.start, Math.min(posVertexCount, group.start + group.count))
   }
 
-  const indexAttr = new THREE.Uint16BufferAttribute(faceCount * 3, 3)
+  const indexAttr = new THREE.Uint16BufferAttribute(faceCount * 3, 3) // should item siz not be one? internallly (array.length/ itemsize) =count
   indexAttr.count = faceCount * 3 // @todo without this the mesh does not show all faces
 
   for (let faceIndex = 0; faceIndex < faceCount; faceIndex += 1) {