Skinned mesh ECS bounding box frustum culling (#8733)

* disable bvh on models with skinned meshes * bvh disable * set up skinned mesh frustum culling components * bounding box culling --------- Co-authored-by: Gheric Speiginer <[email protected]>
EtherealEngine · Sep 13, 2023 · d9b5dc2 · d9b5dc2
1 parent 6351680
commit d9b5dc2
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 19 deletions.
diff --git a/packages/engine/src/scene/components/ModelComponent.ts b/packages/engine/src/scene/components/ModelComponent.ts
@@ -45,8 +45,10 @@ import {
   useOptionalComponent
 } from '../../ecs/functions/ComponentFunctions'
 import { entityExists, useEntityContext } from '../../ecs/functions/EntityFunctions'
+import { BoundingBoxComponent } from '../../interaction/components/BoundingBoxComponents'
 import { SourceType } from '../../renderer/materials/components/MaterialSource'
 import { removeMaterialSource } from '../../renderer/materials/functions/MaterialLibraryFunctions'
+import { FrustumCullCameraComponent } from '../../transform/components/DistanceComponents'
 import { ObjectLayers } from '../constants/ObjectLayers'
 import { addError, removeError } from '../functions/ErrorFunctions'
 import { generateMeshBVH } from '../functions/bvhWorkerPool'
@@ -208,20 +210,23 @@ function ModelReactor() {
 
     if (groupComponent?.value?.find((group: any) => group === scene)) return
     parseGLTFModel(entity)
-    // setComponent(entity, BoundingBoxComponent)
+    setComponent(entity, BoundingBoxComponent)
 
     let active = true
 
     const skinnedMeshSearch = iterateObject3D(
       scene,
-      () => true,
-      (ob: SkinnedMesh) => ob.isSkinnedMesh,
-      false,
-      true
+      (skinnedMesh) => skinnedMesh,
+      (ob: SkinnedMesh) => ob.isSkinnedMesh
     )
+
     if (skinnedMeshSearch[0]) {
       modelComponent.hasSkinnedMesh.set(true)
       modelComponent.generateBVH.set(false)
+      for (const skinnedMesh of skinnedMeshSearch) {
+        skinnedMesh.frustumCulled = false
+      }
+      setComponent(entity, FrustumCullCameraComponent)
     }
 
     if (model.generateBVH) {

diff --git a/packages/engine/src/scene/systems/SceneObjectSystem.tsx b/packages/engine/src/scene/systems/SceneObjectSystem.tsx
@@ -48,7 +48,7 @@ import { defineQuery, getComponent, hasComponent, useOptionalComponent } from '.
 import { defineSystem } from '../../ecs/functions/SystemFunctions'
 import { RendererState } from '../../renderer/RendererState'
 import { registerMaterial, unregisterMaterial } from '../../renderer/materials/functions/MaterialLibraryFunctions'
-import { DistanceFromCameraComponent, FrustumCullCameraComponent } from '../../transform/components/DistanceComponents'
+import { FrustumCullCameraComponent } from '../../transform/components/DistanceComponents'
 import { isMobileXRHeadset } from '../../xr/XRState'
 import { CallbackComponent } from '../components/CallbackComponent'
 import { GroupComponent, GroupQueryReactor, Object3DWithEntity } from '../components/GroupComponent'
@@ -195,12 +195,8 @@ const execute = () => {
     /**
      * do frustum culling here, but only if the object is more than 5 units away
      */
-    const visible =
-      hasComponent(entity, VisibleComponent) &&
-      !(
-        FrustumCullCameraComponent.isCulled[entity] &&
-        DistanceFromCameraComponent.squaredDistance[entity] > minimumFrustumCullDistanceSqr
-      )
+    const visible = hasComponent(entity, VisibleComponent) && !FrustumCullCameraComponent.isCulled[entity]
+
     for (const obj of group) obj.visible = visible
   }
 

diff --git a/packages/engine/src/transform/systems/TransformSystem.ts b/packages/engine/src/transform/systems/TransformSystem.ts
@@ -402,13 +402,13 @@ const execute = () => {
   _projScreenMatrix.multiplyMatrices(camera.projectionMatrix, camera.matrixWorldInverse)
   _frustum.setFromProjectionMatrix(_projScreenMatrix)
 
-  for (const entity of frustumCulledQuery())
-    FrustumCullCameraComponent.isCulled[entity] = _frustum.containsPoint(
-      getComponent(entity, TransformComponent).position
-    )
-      ? 0
-      : 1
-
+  for (const entity of frustumCulledQuery()) {
+    const boundingBox = getOptionalComponent(entity, BoundingBoxComponent)?.box
+    const cull = boundingBox
+      ? _frustum.intersectsBox(boundingBox)
+      : _frustum.containsPoint(getComponent(entity, TransformComponent).position)
+    FrustumCullCameraComponent.isCulled[entity] = cull ? 0 : 1
+  }
   if (localClientEntity) {
     const localClientPosition = getOptionalComponent(localClientEntity, TransformComponent)?.position
     if (localClientPosition) {