Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

IR-48 Created a Tailwind AutoComplete component and updated Radio Component #10254

Merged
merged 30 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
045d1aa
Add Autocomplete component
hurairahmateen May 24, 2024
da0faca
Update Autocomplete dropdown positioning
hurairahmateen May 24, 2024
71a76a5
Update Autocomplete dropdown width
hurairahmateen May 24, 2024
4db196a
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen May 30, 2024
8c4f60d
Refactor AutoComplete component to include onChange prop
hurairahmateen Jun 3, 2024
f4cd63e
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 3, 2024
87abac4
Update Autocomplete options structure
hurairahmateen Jun 3, 2024
b61927e
Add useRef hook to track option selection in AutoComplete component
hurairahmateen Jun 3, 2024
3c46668
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 4, 2024
7bb5ce9
Refactor Radio component to include a description
hurairahmateen Jun 4, 2024
9516238
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 4, 2024
bd26cc9
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 5, 2024
d73f2da
Refactor AutoComplete component to remove unused code
hurairahmateen Jun 5, 2024
5a3adf9
Fix Autocomplete dropdown visibility issue
hurairahmateen Jun 5, 2024
722ae03
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 5, 2024
acb07e1
Fix project permission type bug
hurairahmateen Jun 5, 2024
e0fa2cf
Fix project permission type in patch
hurairahmateen Jun 5, 2024
31071e6
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 6, 2024
b1abab9
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 6, 2024
3f015a9
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 7, 2024
c1b3d45
Merge branch 'dev' into tailwind-autocomplete-component
hurairahmateen Jun 10, 2024
73bfdba
Merge branch 'dev' into tailwind-autocomplete-component
hanzlamateen Jun 10, 2024
0ad5dd4
IR-2538 Updated project-permission service to include createdBy colum…
hurairahmateen Jun 10, 2024
4efb3a8
Merge branch 'dev' into tailwind-autocomplete-component
hanzlamateen Jun 10, 2024
5c42bef
Merge branch 'dev' into tailwind-autocomplete-component
hanzlamateen Jun 10, 2024
8afa189
Cleaned autocomplete
hanzlamateen Jun 10, 2024
f8cc37c
feat: Refactor project-permission.hooks.ts to use explicit type casting
hanzlamateen Jun 10, 2024
b037e25
Merge branch 'dev' into tailwind-autocomplete-component
hanzlamateen Jun 10, 2024
93ccdba
Updated tests
hanzlamateen Jun 10, 2024
501487e
feat: Add 'type' parameter to createPermission function in ProjectSer…
hanzlamateen Jun 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default function ManageUserPermissionModal({
return
}
try {
await ProjectService.createPermission(userInviteCode.value, project.id)
await ProjectService.createPermission(userInviteCode.value, project.id, 'reviewer')
} catch (err) {
NotificationService.dispatchNotify(err.message, { variant: 'error' })
}
Expand Down
9 changes: 6 additions & 3 deletions packages/client-core/src/common/services/ProjectService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ import {
projectPath,
projectPermissionPath,
ProjectType,
ProjectUpdateParams
ProjectUpdateParams,
UserID
} from '@etherealengine/common/src/schema.type.module'
import { Engine } from '@etherealengine/ecs/src/Engine'
import { defineState, getMutableState, useHookstate } from '@etherealengine/hyperflux'
Expand Down Expand Up @@ -176,11 +177,13 @@ export const ProjectService = {
}
},

createPermission: async (userInviteCode: InviteCode, projectId: string) => {
createPermission: async (userInviteCode: InviteCode, projectId: string, type: string) => {
try {
return Engine.instance.api.service(projectPermissionPath).create({
inviteCode: userInviteCode,
projectId: projectId
userId: '' as UserID,
projectId: projectId,
type
})
} catch (err) {
logger.error('Error with creating new project-permission', err)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ export const projectPermissionSchema = Type.Object(
userId: TypedString<UserID>({
format: 'uuid'
}),
createdBy: TypedString<UserID>({
format: 'uuid'
}),
type: Type.String(),
user: Type.Ref(userSchema),
createdAt: Type.String({ format: 'date-time' }),
Expand All @@ -59,7 +62,7 @@ export interface ProjectPermissionType extends Static<typeof projectPermissionSc
export interface ProjectPermissionDatabaseType extends Omit<ProjectPermissionType, 'user'> {}

// Schema for creating new entries
export const projectPermissionDataProperties = Type.Partial(projectPermissionSchema)
export const projectPermissionDataProperties = Type.Pick(projectPermissionSchema, ['projectId', 'userId', 'type'])

export const projectPermissionDataSchema = Type.Intersect(
[
Expand All @@ -76,7 +79,7 @@ export const projectPermissionDataSchema = Type.Intersect(
export interface ProjectPermissionData extends Static<typeof projectPermissionDataSchema> {}

// Schema for updating existing entries
export const projectPermissionPatchSchema = Type.Partial(projectPermissionSchema, {
export const projectPermissionPatchSchema = Type.Pick(projectPermissionSchema, ['type'], {
$id: 'ProjectPermissionPatch'
})
export interface ProjectPermissionPatch extends Static<typeof projectPermissionPatchSchema> {}
Expand All @@ -86,6 +89,7 @@ export const projectPermissionQueryProperties = Type.Pick(projectPermissionSchem
'id',
'projectId',
'userId',
'createdBy',
'type'
])
export const projectPermissionQuerySchema = Type.Intersect(
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/projects/ProjectsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ const ProjectsPage = ({ studioPath }: { studioPath: string }) => {
}

const onCreatePermission = async (userInviteCode: InviteCode, projectId: string) => {
await ProjectService.createPermission(userInviteCode, projectId)
await ProjectService.createPermission(userInviteCode, projectId, 'reviewer')
}

const onPatchPermission = async (id: string, type: string) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
CPAL-1.0 License

The contents of this file are subject to the Common Public Attribution License
Version 1.0. (the "License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://github.com/EtherealEngine/etherealengine/blob/dev/LICENSE.
The License is based on the Mozilla Public License Version 1.1, but Sections 14
and 15 have been added to cover use of software over a computer network and
provide for limited attribution for the Original Developer. In addition,
Exhibit A has been modified to be consistent with Exhibit B.

Software distributed under the License is distributed on an "AS IS" basis,
WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License for the
specific language governing rights and limitations under the License.

The Original Code is Ethereal Engine.

The Original Developer is the Initial Developer. The Initial Developer of the
Original Code is the Ethereal Engine team.

All portions of the code written by the Ethereal Engine team are Copyright © 2021-2023
Ethereal Engine. All Rights Reserved.
*/

import { projectPermissionPath } from '@etherealengine/common/src/schemas/projects/project-permission.schema'
import type { Knex } from 'knex'

/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
export async function up(knex: Knex): Promise<void> {
await knex.raw('SET FOREIGN_KEY_CHECKS=0')

await addCreatedByColumn(knex, projectPermissionPath)

await knex.raw('SET FOREIGN_KEY_CHECKS=1')
}

/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
export async function down(knex: Knex): Promise<void> {
await knex.raw('SET FOREIGN_KEY_CHECKS=0')

await dropCreatedByColumn(knex, projectPermissionPath)

await knex.raw('SET FOREIGN_KEY_CHECKS=1')
}

export async function addCreatedByColumn(knex: Knex, tableName: string) {
const createdByColumnExists = await knex.schema.hasColumn(tableName, 'createdBy')

if (createdByColumnExists === false) {
await knex.schema.alterTable(tableName, async (table) => {
//@ts-ignore
table.uuid('createdBy', 36).collate('utf8mb4_bin').nullable().index()
table.foreign('createdBy').references('id').inTable('user').onDelete('CASCADE').onUpdate('CASCADE')
})
}
}

export async function dropCreatedByColumn(knex: Knex, tableName: string) {
const createdByColumnExists = await knex.schema.hasColumn(tableName, 'createdBy')

if (createdByColumnExists === true) {
await knex.schema.alterTable(tableName, async (table) => {
table.dropForeign('createdBy')
table.dropColumn('createdBy')
})
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ All portions of the code written by the Ethereal Engine team are Copyright © 20
Ethereal Engine. All Rights Reserved.
*/

import { BadRequest, Forbidden } from '@feathersjs/errors'
import { Paginated } from '@feathersjs/feathers'
import { hooks as schemaHooks } from '@feathersjs/schema'
import { disallow, discardQuery, iff, iffElse, isProvider } from 'feathers-hooks-common'

import { INVITE_CODE_REGEX, USER_ID_REGEX } from '@etherealengine/common/src/constants/IdConstants'
import {
ProjectPermissionData,
Expand All @@ -40,7 +35,12 @@ import {
} from '@etherealengine/common/src/schemas/projects/project-permission.schema'
import { projectPath } from '@etherealengine/common/src/schemas/projects/project.schema'
import { InviteCode, UserID, UserType, userPath } from '@etherealengine/common/src/schemas/user/user.schema'
import setLoggedInUserData from '@etherealengine/server-core/src/hooks/set-loggedin-user-in-body'
import { checkScope } from '@etherealengine/spatial/src/common/functions/checkScope'
import { BadRequest, Forbidden } from '@feathersjs/errors'
import { Paginated } from '@feathersjs/feathers'
import { hooks as schemaHooks } from '@feathersjs/schema'
import { disallow, discardQuery, iff, iffElse, isProvider } from 'feathers-hooks-common'

import { HookContext } from '../../../declarations'
import logger from '../../ServerLogger'
Expand Down Expand Up @@ -75,7 +75,7 @@ const ensureInviteCode = async (context: HookContext<ProjectPermissionService>)
}
if (data[0].userId && INVITE_CODE_REGEX.test(data[0].userId)) {
data[0].inviteCode = data[0].userId as string as InviteCode
delete data[0].userId
delete (data[0] as any).userId
}
context.data = data[0]
}
Expand Down Expand Up @@ -131,7 +131,7 @@ const checkExistingPermissions = async (context: HookContext<ProjectPermissionSe
existingPermissionsCount.length === 0 ||
((await checkScope(selfUser, 'projects', 'write')) && selfUser.id === users.data[0].id)
? 'owner'
: 'editor'
: data[0].type
}
} catch (err) {
logger.error(err)
Expand Down Expand Up @@ -187,7 +187,7 @@ const ensureTypeInPatch = async (context: HookContext<ProjectPermissionService>)
}

const data: ProjectPermissionPatch = context.data as ProjectPermissionPatch
context.data = { type: data.type === 'owner' ? 'owner' : 'editor' }
context.data = { type: data.type === 'owner' ? 'owner' : data.type } as ProjectPermissionData
}

/**
Expand Down Expand Up @@ -224,6 +224,7 @@ export default {
iff(isProvider('external'), verifyProjectOwner()),
() => schemaHooks.validateData(projectPermissionDataValidator),
schemaHooks.resolveData(projectPermissionDataResolver),
setLoggedInUserData('createdBy'),
ensureInviteCode,
checkExistingPermissions
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ describe('project-permission.test', () => {
project1Permission2 = await app.service(projectPermissionPath).create(
{
projectId: project1.id,
userId: user2.id
userId: user2.id,
type: 'editor'
},
params
)
Expand All @@ -216,7 +217,8 @@ describe('project-permission.test', () => {
const duplicate = await app.service(projectPermissionPath).create(
{
projectId: project1.id,
userId: user2.id
userId: user2.id,
type: 'editor'
},
params
)
Expand All @@ -237,7 +239,8 @@ describe('project-permission.test', () => {
await app.service(projectPermissionPath).create(
{
projectId: 'abcdefg',
userId: user2.id
userId: user2.id,
type: 'editor'
},
params
)
Expand All @@ -259,7 +262,8 @@ describe('project-permission.test', () => {
await app.service(projectPermissionPath).create(
{
projectId: project1.id,
userId: 'abcdefg' as UserID
userId: 'abcdefg' as UserID,
type: 'editor'
},
params
)
Expand All @@ -281,7 +285,8 @@ describe('project-permission.test', () => {
const res = await app.service(projectPermissionPath).create(
{
projectId: project1.id,
userId: user3.id
userId: user3.id,
type: 'editor'
},
params
)
Expand All @@ -303,7 +308,8 @@ describe('project-permission.test', () => {
await app.service(projectPermissionPath).create(
{
projectId: project1.id,
userId: user3.id
userId: user3.id,
type: 'editor'
},
params
)
Expand Down Expand Up @@ -353,8 +359,6 @@ describe('project-permission.test', () => {
const update = (await app.service(projectPermissionPath).patch(
project1Permission2.id,
{
projectId: project1.id,
userId: 'abcdefg' as UserID,
type: 'owner'
}
// params
Expand All @@ -374,8 +378,6 @@ describe('project-permission.test', () => {
const update = (await app.service(projectPermissionPath).patch(
project1Permission2.id,
{
projectId: project1.id,
userId: user2.id,
type: 'editor'
},
params
Expand All @@ -397,8 +399,6 @@ describe('project-permission.test', () => {
await app.service(projectPermissionPath).patch(
project1Permission2.id,
{
projectId: project1.id,
userId: user3.id,
type: ''
},
params
Expand Down Expand Up @@ -427,8 +427,6 @@ describe('project-permission.test', () => {
await app.service(projectPermissionPath).patch(
project1Permission2.id,
{
projectId: project1.id,
userId: user3.id,
type: ''
},
params
Expand Down
63 changes: 63 additions & 0 deletions packages/ui/src/primitives/tailwind/Autocomplete/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
CPAL-1.0 License

The contents of this file are subject to the Common Public Attribution License
Version 1.0. (the "License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://github.com/EtherealEngine/etherealengine/blob/dev/LICENSE.
The License is based on the Mozilla Public License Version 1.1, but Sections 14
and 15 have been added to cover use of software over a computer network and
provide for limited attribution for the Original Developer. In addition,
Exhibit A has been modified to be consistent with Exhibit B.

Software distributed under the License is distributed on an "AS IS" basis,
WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License for the
specific language governing rights and limitations under the License.

The Original Code is Ethereal Engine.

The Original Developer is the Initial Developer. The Initial Developer of the
Original Code is the Ethereal Engine team.

All portions of the code written by the Ethereal Engine team are Copyright © 2021-2023
Ethereal Engine. All Rights Reserved.
*/

import React from 'react'
import Input from '../Input'

export type AutoCompleteOptionsType = { label: string; value: any }

export interface AutoCompleteProps {
value: string
options: AutoCompleteOptionsType[]
className?: string
placeholder?: string
onSelect: (value: any) => void
onChange: (e: React.ChangeEvent<HTMLInputElement>) => void
}

const AutoComplete = ({ options, onSelect, placeholder, className, value, onChange }: AutoCompleteProps) => {
return (
<div className={`relative ${className}`}>
<Input value={value} placeholder={placeholder} className="w-full" onChange={onChange} />
{options.length > 0 && (
<div className="fixed left-10 right-0 z-[60] mt-2 w-1/2 rounded border border-theme-primary bg-theme-surface-main">
<ul className="max-h-40 overflow-auto [&>li]:px-4 [&>li]:py-2">
{options.map((option, index) => (
<li
key={index}
className="cursor-pointer px-4 py-2 text-theme-secondary"
onClick={() => onSelect(option.value)}
>
{option.label}
</li>
))}
</ul>
</div>
)}
</div>
)
}

export default AutoComplete
Loading
Loading