-
-
Notifications
You must be signed in to change notification settings - Fork 0
IR-2155: Check for project permissions in static resource service #10310
Conversation
@HexaField FYI, if this is related to the refactor you are currently doing in #10304. |
3febf4d
to
2807c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✅
Just 2 improvements.
packages/ui/src/components/editor/panels/Files/browserGrid/index.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/editor/panels/Files/browserGrid/index.tsx
Outdated
Show resolved
Hide resolved
packages/editor/src/components/assets/FileBrowser/FileBrowserGrid.tsx
Outdated
Show resolved
Hide resolved
packages/editor/src/components/assets/FileBrowser/FileBrowserGrid.tsx
Outdated
Show resolved
Hide resolved
packages/server-core/src/media/file-browser/file-browser.class.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/server-core/src/media/static-resource/static-resource.hooks.ts
Outdated
Show resolved
Hide resolved
packages/server-core/src/media/static-resource/static-resource.hooks.ts
Outdated
Show resolved
Hide resolved
…ck permissions on remove static ressource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution here adding projectName to the file browser will be incorrect if the user leaves the editor's active project and enters another one. I have a solution implemented here #10304 that addresses that properly, so I don't think we need to worry about that here. I am also rewriting a lot of the backend services in that PR, so the hooks will change again, and I need these changes in to continue that work, so I will address the name concern there too.
* dev: Made userId in project-setting.schema.ts optional (#10357) Refactor customRoutes.tsx and ProjectConfigInterface.ts to include component props (#10359) show loading when adding scene (#10345) Fixed Project Settings table (#10360) IR-2155: Check for project permissions in static resource service (#10310) studio: add main menu (#10303) remove unnecessary name overrides in vrm autoconversion (#10356)
@HexaField Do I close #10353 then? |
Yes ive closed it |
Summary
adds checks for project permissions in static resources service
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps
Go into the studio with an account that only has editor:write scope
Select the files tab on the bottom
You should be able to see files and navigate through your project folders.