Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

IR-2155: Check for project permissions in static resource service #10310

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

jose-galvan
Copy link
Collaborator

@jose-galvan jose-galvan commented Jun 4, 2024

Summary

adds checks for project permissions in static resources service

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

Go into the studio with an account that only has editor:write scope
Select the files tab on the bottom
You should be able to see files and navigate through your project folders.

@hanzlamateen
Copy link
Member

hanzlamateen commented Jun 4, 2024

@HexaField FYI, if this is related to the refactor you are currently doing in #10304.

@jose-galvan jose-galvan force-pushed the jg/ir-2155 branch 2 times, most recently from 3febf4d to 2807c85 Compare June 5, 2024 05:46
@jose-galvan jose-galvan marked this pull request as ready for review June 5, 2024 05:50
Copy link
Collaborator

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅
Just 2 improvements.

Copy link
Collaborator

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Please make sure check-lint github action is passing by fixing the styles/formating of file.

image

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution here adding projectName to the file browser will be incorrect if the user leaves the editor's active project and enters another one. I have a solution implemented here #10304 that addresses that properly, so I don't think we need to worry about that here. I am also rewriting a lot of the backend services in that PR, so the hooks will change again, and I need these changes in to continue that work, so I will address the name concern there too.

@HexaField HexaField merged commit 5406697 into dev Jun 11, 2024
28 checks passed
@HexaField HexaField deleted the jg/ir-2155 branch June 11, 2024 04:54
MbfloydIR added a commit that referenced this pull request Jun 11, 2024
* dev:
  Made userId in project-setting.schema.ts optional (#10357)
  Refactor customRoutes.tsx and ProjectConfigInterface.ts to include component props (#10359)
  show loading when adding scene (#10345)
  Fixed Project Settings table (#10360)
  IR-2155: Check for project permissions in static resource service (#10310)
  studio: add main menu (#10303)
  remove unnecessary name overrides in vrm autoconversion (#10356)
@jose-galvan
Copy link
Collaborator Author

This solution here adding projectName to the file browser will be incorrect if the user leaves the editor's active project and enters another one. I have a solution implemented here #10304 that addresses that properly, so I don't think we need to worry about that here. I am also rewriting a lot of the backend services in that PR, so the hooks will change again, and I need these changes in to continue that work, so I will address the name concern there too.

@HexaField Do I close #10353 then?

@HexaField
Copy link
Member

This solution here adding projectName to the file browser will be incorrect if the user leaves the editor's active project and enters another one. I have a solution implemented here #10304 that addresses that properly, so I don't think we need to worry about that here. I am also rewriting a lot of the backend services in that PR, so the hooks will change again, and I need these changes in to continue that work, so I will address the name concern there too.

@HexaField Do I close #10353 then?

Yes ive closed it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants