This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
scene name validation on save as and rename #10347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achen5671
approved these changes
Jun 10, 2024
SYBIOTE
approved these changes
Jun 10, 2024
HexaField
suggested changes
Jun 10, 2024
done and added the validation in common package |
hanzlamateen
suggested changes
Jun 14, 2024
HexaField
approved these changes
Jun 18, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 18, 2024
* dev: IR-1775-Changes-for-examples (#10387) Implement gizmo presets and optimize code (#10257) scene name validation on save as and rename (#10347) prevent scene name overflow (#10400) App core tech debt componentization (#10395) add dependency to hierarchy generation that updates with every sourced entity created (#10401) hot fix install projects query (#10398) Support ReactNode in ModalHeader (#10391) [IR-2545] studio: Assets Panel ContextMenu (#10390) Removed FullscreenContainer, replaced with fullscreen on document.body (#10352) Ir 2564 fix fog (#10394) fix regressions # Conflicts: # packages/ui/src/components/editor/panels/Files/container/index.tsx
MbfloydIR
added a commit
that referenced
this pull request
Jun 18, 2024
* dev: IR-1775-Changes-for-examples (#10387) Implement gizmo presets and optimize code (#10257) scene name validation on save as and rename (#10347) prevent scene name overflow (#10400) App core tech debt componentization (#10395) add dependency to hierarchy generation that updates with every sourced entity created (#10401) hot fix install projects query (#10398) Support ReactNode in ModalHeader (#10391) [IR-2545] studio: Assets Panel ContextMenu (#10390) Removed FullscreenContainer, replaced with fullscreen on document.body (#10352) Ir 2564 fix fog (#10394) fix regressions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
user input scene name validation
Subtasks Checklist
Breaking Changes
References
https://tsu.atlassian.net/browse/IR-2453
https://tsu.atlassian.net/browse/IR-2531
https://tsu.atlassian.net/browse/IR-1446
QA Steps