This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Remove unnecessary name overrides in vrm autoconversion #10356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
approved these changes
Jun 10, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 11, 2024
* dev: Made userId in project-setting.schema.ts optional (#10357) Refactor customRoutes.tsx and ProjectConfigInterface.ts to include component props (#10359) show loading when adding scene (#10345) Fixed Project Settings table (#10360) IR-2155: Check for project permissions in static resource service (#10310) studio: add main menu (#10303) remove unnecessary name overrides in vrm autoconversion (#10356)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
removes an unnecessary name override that potentially prevents animation binding working properly, observed in https://github.com/AidanCaruso/mocapbakery
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps