Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

App core tech debt componentization #10395

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Jun 15, 2024

Summary

  • webapp injection into component
  • auth login hook
  • notification to components
  • simplify engine loader lazy load
  • refactor tailwind theme provider into hook

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

Copy link
Collaborator

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes and then we are good to go!
Once we remove material-ui, a lot more can be removed. I will start removing it in the next few weeks with the studio first.

@HexaField HexaField requested a review from aditya-mitra June 17, 2024 08:30
Copy link
Collaborator

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

@HexaField HexaField merged commit ee03b64 into dev Jun 17, 2024
28 checks passed
@HexaField HexaField deleted the app-core-tech-debt-componentization branch June 17, 2024 21:20
MbfloydIR added a commit that referenced this pull request Jun 18, 2024
* dev:
  IR-1775-Changes-for-examples (#10387)
  Implement gizmo presets and optimize code (#10257)
  scene name validation on save as and rename (#10347)
  prevent scene name overflow (#10400)
  App core tech debt componentization (#10395)
  add dependency to hierarchy generation that updates with every sourced entity created (#10401)
  hot fix install projects query (#10398)
  Support ReactNode in ModalHeader (#10391)
  [IR-2545] studio: Assets Panel ContextMenu (#10390)
  Removed FullscreenContainer, replaced with fullscreen on document.body (#10352)
  Ir 2564 fix fog (#10394)
  fix regressions

# Conflicts:
#	packages/ui/src/components/editor/panels/Files/container/index.tsx
MbfloydIR added a commit that referenced this pull request Jun 18, 2024
* dev:
  IR-1775-Changes-for-examples (#10387)
  Implement gizmo presets and optimize code (#10257)
  scene name validation on save as and rename (#10347)
  prevent scene name overflow (#10400)
  App core tech debt componentization (#10395)
  add dependency to hierarchy generation that updates with every sourced entity created (#10401)
  hot fix install projects query (#10398)
  Support ReactNode in ModalHeader (#10391)
  [IR-2545] studio: Assets Panel ContextMenu (#10390)
  Removed FullscreenContainer, replaced with fullscreen on document.body (#10352)
  Ir 2564 fix fog (#10394)
  fix regressions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants