Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

IR-1791: Fix Hierarchy Panel Updating on GLTF load #10401

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

dinomut1
Copy link
Member

Adds Source Component query dependency to hierarchy tree generation. This forces the hierarchy to update every time a new sourced entity is added to the scene (ie on GLTF load)

Closes https://tsu.atlassian.net/browse/IR-1791

@dinomut1 dinomut1 requested review from JT00y and aditya-mitra June 17, 2024 19:47
Copy link
Contributor

@JT00y JT00y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this fix the problem.

@dinomut1 dinomut1 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into dev with commit 282861d Jun 17, 2024
28 checks passed
@dinomut1 dinomut1 deleted the IR-1791-fix-hierarchy-update branch June 17, 2024 20:00
MbfloydIR added a commit that referenced this pull request Jun 18, 2024
* dev:
  IR-1775-Changes-for-examples (#10387)
  Implement gizmo presets and optimize code (#10257)
  scene name validation on save as and rename (#10347)
  prevent scene name overflow (#10400)
  App core tech debt componentization (#10395)
  add dependency to hierarchy generation that updates with every sourced entity created (#10401)
  hot fix install projects query (#10398)
  Support ReactNode in ModalHeader (#10391)
  [IR-2545] studio: Assets Panel ContextMenu (#10390)
  Removed FullscreenContainer, replaced with fullscreen on document.body (#10352)
  Ir 2564 fix fog (#10394)
  fix regressions

# Conflicts:
#	packages/ui/src/components/editor/panels/Files/container/index.tsx
MbfloydIR added a commit that referenced this pull request Jun 18, 2024
* dev:
  IR-1775-Changes-for-examples (#10387)
  Implement gizmo presets and optimize code (#10257)
  scene name validation on save as and rename (#10347)
  prevent scene name overflow (#10400)
  App core tech debt componentization (#10395)
  add dependency to hierarchy generation that updates with every sourced entity created (#10401)
  hot fix install projects query (#10398)
  Support ReactNode in ModalHeader (#10391)
  [IR-2545] studio: Assets Panel ContextMenu (#10390)
  Removed FullscreenContainer, replaced with fullscreen on document.body (#10352)
  Ir 2564 fix fog (#10394)
  fix regressions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants