This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Jun 20, 2024
aditya-mitra
changed the title
Add isEditor in Editor2Page and fix drop shadows
Lit and Unlit modes implementation
Jun 20, 2024
for the lit - unlit implementation, I hide all light in unlit mode and turn on the lights when in any other mode |
HexaField
suggested changes
Jul 1, 2024
HexaField
suggested changes
Jul 3, 2024
HexaField
suggested changes
Jul 3, 2024
HexaField
suggested changes
Jul 4, 2024
MichaelEstes
previously requested changes
Jul 10, 2024
packages/engine/src/scene/components/PrimitiveGeometryComponent.ts
Outdated
Show resolved
Hide resolved
SYBIOTE
requested review from
dinomut1,
speigg,
CITIZENDOT,
AidanCaruso,
DanielBelmes,
heysokam,
MbfloydIR and
SamMazerIR
as code owners
July 14, 2024 16:49
Drop shadows
HexaField
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working fantastic now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes the drop shadows in the application. The changes ensure that the drop shadows are correctly applied to mesh and model and primitive geom entities.
Subtasks Checklist
Breaking Changes
References
https://tsu.atlassian.net/browse/IR-2264
QA Steps