Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Lit and Unlit modes implementation #10408

Merged
merged 30 commits into from
Jul 17, 2024
Merged

Lit and Unlit modes implementation #10408

merged 30 commits into from
Jul 17, 2024

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Jun 18, 2024

Summary

fixes the drop shadows in the application. The changes ensure that the drop shadows are correctly applied to mesh and model and primitive geom entities.

Subtasks Checklist

Breaking Changes

References

https://tsu.atlassian.net/browse/IR-2264

QA Steps

@aditya-mitra aditya-mitra requested a review from HexaField June 20, 2024 04:21
@aditya-mitra aditya-mitra changed the title Add isEditor in Editor2Page and fix drop shadows Lit and Unlit modes implementation Jun 20, 2024
@aditya-mitra aditya-mitra marked this pull request as draft June 20, 2024 17:27
@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 1, 2024

for the lit - unlit implementation, I hide all light in unlit mode and turn on the lights when in any other mode
in unlit mode we add a temp ambient light to the scene and remove it when we are in any other mode

@SYBIOTE SYBIOTE marked this pull request as ready for review July 1, 2024 22:56
@SYBIOTE SYBIOTE requested a review from HexaField July 2, 2024 11:18
@SYBIOTE SYBIOTE requested a review from HexaField July 5, 2024 18:01
@HexaField HexaField requested a review from MichaelEstes July 10, 2024 22:14
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fantastic now

@HexaField HexaField added this pull request to the merge queue Jul 17, 2024
Merged via the queue into dev with commit 6dfbb94 Jul 17, 2024
25 checks passed
@HexaField HexaField deleted the lit-unlit-render-mode branch July 17, 2024 01:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants