This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Append hash to bust cache on all static resources #10411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
suggested changes
Jun 19, 2024
There was a problem hiding this comment.
There's some bugs around saving scenes. If you change a scene and then save it, the hash is getting saved onto the scene key in the DB, which we don't want. If you change the scene and save it again, things get weirder, with the scene now having a key of e.g. projects/default-project/public/scenes/defaulthash91b94e.gltf?hash=5129ca and a new GLTF file, of type 'file', with a key like projects/default-project/public/scenes/defaulthash91b94e.gltf. Hopefully fixing the former prevents the latter from happening.
barankyle
approved these changes
Jun 20, 2024
MichaelEstes
approved these changes
Jun 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps