Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Allow the compression or multiple selected images/models and the modification of properties of multiple files #10461

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

Rezmason
Copy link
Contributor

@Rezmason Rezmason commented Jun 26, 2024

Summary

Currently, if the user selects one file in the file browser, they can compress it (if it is an image or model) or modify its properties.

The work in this PR allows the same UI to be used to compress or modify properties of multiple selected files in the file browser at once.

References

https://tsu.atlassian.net/browse/IR-2340

QA Steps

@Rezmason Rezmason force-pushed the jeremy-IR-2340-multiple-file-properties branch 5 times, most recently from d533e74 to 962e794 Compare July 2, 2024 22:57
@Rezmason Rezmason changed the title WIP: Allow the compression or multiple selected images/models and the modification of properties of multiple files Allow the compression or multiple selected images/models and the modification of properties of multiple files Jul 2, 2024
@Rezmason Rezmason requested review from aditya-mitra and dinomut1 July 2, 2024 23:00
Copy link
Collaborator

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good currently

Once #10397 and #10498 get merged, we will need to refactor FileProperties and ImageCompressionPanel

While opening the model compression menu, the 3 default LOD levels which were previously present have become absent
image

when trying to add an LOD, we are getting thrown with an error
image

Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast from 07-03-2024 12:55:54 PM.webm
Running into an issue where when multiple files are selected, the properties panel doesn't show up until i click on an individual file afterward.

@Rezmason Rezmason force-pushed the jeremy-IR-2340-multiple-file-properties branch 2 times, most recently from 2a507af to c340ddc Compare July 9, 2024 16:44
@Rezmason Rezmason force-pushed the jeremy-IR-2340-multiple-file-properties branch from 4182006 to 59f2b50 Compare July 10, 2024 17:27
@Rezmason
Copy link
Contributor Author

Fixed several bugs including the ones mentioned here.

Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast from 07-10-2024 01:58:05 PM.webm
Seeing issue with adding tags

Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific. We'll optimize the one feathers call per selected file later

@dinomut1 dinomut1 enabled auto-merge July 10, 2024 22:11
@dinomut1 dinomut1 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into dev with commit 7805246 Jul 11, 2024
25 checks passed
@dinomut1 dinomut1 deleted the jeremy-IR-2340-multiple-file-properties branch July 11, 2024 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants