-
-
Notifications
You must be signed in to change notification settings - Fork 0
Allow the compression or multiple selected images/models and the modification of properties of multiple files #10461
Conversation
d533e74
to
962e794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good currently
Once #10397 and #10498 get merged, we will need to refactor FileProperties and ImageCompressionPanel
While opening the model compression menu, the 3 default LOD levels which were previously present have become absent
when trying to add an LOD, we are getting thrown with an error
packages/ui/src/components/editor/panels/Files/browserGrid/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screencast from 07-03-2024 12:55:54 PM.webm
Running into an issue where when multiple files are selected, the properties panel doesn't show up until i click on an individual file afterward.
2a507af
to
c340ddc
Compare
…ted now from Files/container/index.tsx
…now accept a FileType[] instead of a FileType, which is the files selected in the file browser.
4182006
to
59f2b50
Compare
Fixed several bugs including the ones mentioned here. |
…into jeremy-IR-2340-multiple-file-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screencast from 07-10-2024 01:58:05 PM.webm
Seeing issue with adding tags
…hub.com/EtherealEngine/etherealengine into jeremy-IR-2340-multiple-file-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific. We'll optimize the one feathers call per selected file later
Summary
Currently, if the user selects one file in the file browser, they can compress it (if it is an image or model) or modify its properties.
The work in this PR allows the same UI to be used to compress or modify properties of multiple selected files in the file browser at once.
References
https://tsu.atlassian.net/browse/IR-2340
QA Steps