This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
[IR-3547] studio: show unsaved changes dialog when switching between scenes #10921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtlehrer
requested review from
aditya-mitra,
SYBIOTE,
CITIZENDOT and
dinomut1
as code owners
August 8, 2024 15:57
aditya-mitra
suggested changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aditya-mitra
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
(I modified the beforeUnloadEvent to use browser's alert instead of our own alert because the former solution is cross-browser friendly and also gives the user a way to force close the window)
MbfloydIR
added a commit
that referenced
this pull request
Aug 13, 2024
* dev: IR-3602-Changing-CSM-cascade-count-or-tonemapping-spams-errors (#10926) hotfix gizmo zeroed position on rigidbody entities (#10943) Add download progress bar and optimize util files (#10914) [IR-3547] studio: show unsaved changes dialog when switching between scenes (#10921) added tailwind class to break the line in the middle of words to prevent overflowing the alocated space (#10944) Updating the description of hemisphere lights to better explain what they do and why. (#10945) Left aligning the text in the "Add Component" and "Add Entity" menus (#10946) studio: open context menu on file menu right click (#10908) Fixed a bug with project PUTs without commit SHAs (#10942) IR-2873 Fix disabled state for select dropdown arrow (#10950) IR-3700: Added search by sso/email in user table (#10929) IR-3053: Add project-history service (#10736) Component dependencies (#10916) [IR-3324] studio: drag-n-drop folders (#10737) prevent scene from disappearing when double-clicking on a HierarchyTreeNode (#10932) fix tooltip css applied to all popups (#10938)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IR-3547
confirmedSaveIfModified
function, which can now be used to check for unsaved changes and display the Unsaved Changes confirmation dialog across the appconfirmedSaveIfModified
function when clicking on theSceneItem
component to switch between scenesScreen.Recording.2024-08-08.at.11.18.07.AM.mov
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps