This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
detect-port does not detect UDP processes running on a port. Switched to running lsof and searching through its outputs to determine if a port is in use.
References
closes #8464
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
🤖 Generated by Copilot at 88e303b
Summary
🗑️🔧🔄
Removed the
detect-port
dependency and used thelsof
command instead for port checking in the instance server. Fixed a typo in theWebRTCFunctions.ts
file.Walkthrough
detect-port
dependency frominstanceserver
package (link)detect
import withexec
import fromchild_process
module inWebRTCFunctions.ts
(link)promisify
import fromutil
module inWebRTCFunctions.ts
to convertexec
to a promise-based function (link)getNewOffset
function inWebRTCFunctions.ts
to takelsofResult
as an additional parameter and search for port number in it instead of usingdetect
(link)lsofResult
variable inWebRTCFunctions.ts
to store the output ofexecAsync
function that runslsof
command to list open ports (link)webRtcServerOptions
object inWebRTCFunctions.ts
to useip
property instead ofipAddress
and passlsofResult.stdout
togetNewOffset
function calls (link)