forked from 0xPolygon/polygon-edge
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ECDSAKey
and decouple from ethgo
lib transactions signing logic
#112
Merged
goran-ethernal
merged 33 commits into
develop
from
feat/decouple-from-ethgo-tx-signing-logic
Mar 21, 2024
Merged
Introduce ECDSAKey
and decouple from ethgo
lib transactions signing logic
#112
goran-ethernal
merged 33 commits into
develop
from
feat/decouple-from-ethgo-tx-signing-logic
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
feat/remove-btcd-dependency
branch
from
February 11, 2024 20:25
b459860
to
61f7218
Compare
Stefan-Ethernal
force-pushed
the
feat/decouple-from-ethgo-tx-signing-logic
branch
from
February 11, 2024 20:25
4475fca
to
5ac1579
Compare
Stefan-Ethernal
changed the title
Introduce ECDSAKey and decouple from ethgo transactions signing logic
Introduce Feb 12, 2024
ECDSAKey
and decouple from ethgo
lib transactions signing logic
Base automatically changed from
feat/remove-btcd-dependency
to
feature/berlin
February 12, 2024 13:04
Stefan-Ethernal
force-pushed
the
feat/decouple-from-ethgo-tx-signing-logic
branch
5 times, most recently
from
February 12, 2024 19:24
54f698f
to
ef714fb
Compare
Stefan-Ethernal
force-pushed
the
feat/decouple-from-ethgo-tx-signing-logic
branch
5 times, most recently
from
February 26, 2024 06:32
565b4a9
to
4c4a220
Compare
dusannosovic-ethernal
force-pushed
the
feat/decouple-from-ethgo-tx-signing-logic
branch
from
March 18, 2024 11:55
8a71399
to
b0656e8
Compare
goran-ethernal
previously approved these changes
Mar 21, 2024
goran-ethernal
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces
ECDSAKey
which is used to encapsulate ECDSA private, public key and Ethereum address. As a consequence, transaction signing logic needed to be changed to rely on crypto.Key instead ofethgo.Key
interface and instead of theethgo
abstraction forTransaction
andtransaction signers
, the abstractions from the Blade are used.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it