Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ECDSAKey and decouple from ethgo lib transactions signing logic #112

Merged
merged 33 commits into from
Mar 21, 2024

Conversation

Stefan-Ethernal
Copy link

@Stefan-Ethernal Stefan-Ethernal commented Feb 11, 2024

Description

The PR introduces ECDSAKey which is used to encapsulate ECDSA private, public key and Ethereum address. As a consequence, transaction signing logic needed to be changed to rely on crypto.Key instead of ethgo.Key interface and instead of the ethgo abstraction for Transaction and transaction signers, the abstractions from the Blade are used.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/remove-btcd-dependency branch from b459860 to 61f7218 Compare February 11, 2024 20:25
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/decouple-from-ethgo-tx-signing-logic branch from 4475fca to 5ac1579 Compare February 11, 2024 20:25
@Stefan-Ethernal Stefan-Ethernal changed the title Introduce ECDSAKey and decouple from ethgo transactions signing logic Introduce ECDSAKey and decouple from ethgo lib transactions signing logic Feb 12, 2024
Base automatically changed from feat/remove-btcd-dependency to feature/berlin February 12, 2024 13:04
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/decouple-from-ethgo-tx-signing-logic branch 5 times, most recently from 54f698f to ef714fb Compare February 12, 2024 19:24
Base automatically changed from feature/berlin to develop February 19, 2024 11:04
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/decouple-from-ethgo-tx-signing-logic branch 5 times, most recently from 565b4a9 to 4c4a220 Compare February 26, 2024 06:32
@dusannosovic-ethernal dusannosovic-ethernal force-pushed the feat/decouple-from-ethgo-tx-signing-logic branch from 8a71399 to b0656e8 Compare March 18, 2024 11:55
@goran-ethernal goran-ethernal deleted the feat/decouple-from-ethgo-tx-signing-logic branch March 19, 2024 08:52
@goran-ethernal goran-ethernal restored the feat/decouple-from-ethgo-tx-signing-logic branch March 19, 2024 08:53
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review March 20, 2024 14:34
command/bridge/helper/utils.go Outdated Show resolved Hide resolved
command/bridge/helper/utils.go Outdated Show resolved Hide resolved
command/validator/unstake/unstake.go Outdated Show resolved Hide resolved
consensus/polybft/checkpoint_manager.go Outdated Show resolved Hide resolved
consensus/polybft/exit_relayer.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
txrelayer/txrelayer.go Outdated Show resolved Hide resolved
txrelayer/txrelayer.go Outdated Show resolved Hide resolved
txrelayer/txrelayer.go Outdated Show resolved Hide resolved
goran-ethernal
goran-ethernal previously approved these changes Mar 21, 2024
@goran-ethernal goran-ethernal merged commit a76534d into develop Mar 21, 2024
10 checks passed
@goran-ethernal goran-ethernal deleted the feat/decouple-from-ethgo-tx-signing-logic branch March 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants